systemd: respect USE_LDCONFIG when setting default PACKAGECONFIG
PATCH 1/1 systemd: respect USE_LDCONFIG when setting default PACKAGECONFIG
Avoid trying to call ldconfig at run-time in distros which force USE_LDCONFIG to 0 and therefore don't provide it.
--- meta/recipes-core/systemd/systemd_232.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_232.bb +3 -1
@@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" +USE_LDCONFIG ?= "1" + PACKAGECONFIG ??= "xz \ - ldconfig \ + ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
Signature · 1 line
1.9.1
Quoted 13 lines · Andre McCurdy
Avoid trying to call ldconfig at run-time in distros which force
USE_LDCONFIGto 0 and therefore don't provide it.Signed-off-by Andre McCurdy <[email protected]>--- meta/recipes-core/systemd/systemd_232.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-core/systemd/systemd_232.bb +0
-0
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 42
Quoted 4 lines
meta/recipes-core/systemd/systemd_232.bb +1
-0@@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" +USE_LDCONFIG ?= "1"
now that we have more recipes using this variables. I think it should to global config space. May be have it as a DISTRO_FEATURE is more appropriate
Quoted 15 lines
meta/recipes-core/systemd/systemd_232.bb +2
-2+ PACKAGECONFIG ??= "xz \ - ldconfig \ + ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \ --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 17 lines · Khem Raj
Quoted 16 lines · Andre McCurdy
Avoid trying to call ldconfig at run-time in distros which force
USE_LDCONFIGto 0 and therefore don't provide it.Signed-off-by Andre McCurdy <[email protected]>--- meta/recipes-core/systemd/systemd_232.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-core/systemd/systemd_232.bb +0
-0@@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
Quoted 5 lines
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 42
Quoted 1 line
meta/recipes-core/systemd/systemd_232.bb +1
-0+USE_LDCONFIG ?= "1"now that we have more recipes using this variables. I think it should to global config space. May be have it as a
DISTRO_FEATUREis more appropriate
Patches for both approaches have now been sent to the list.
Quoted 15 lines
Quoted 15 lines
meta/recipes-core/systemd/systemd_232.bb +2
-2+ PACKAGECONFIG ??= "xz \ - ldconfig \ + ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \ --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 4 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
Quoted 2 lines · Andre McCurdy
Avoid trying to call ldconfig at run-time in distros which force
USE_LDCONFIGto 0 and therefore don't provide it.
Ping.
Perhaps merge this simple patch first if there's no consensus on adding a distro config.
Quoted 36 lines
Quoted 13 lines
Quoted 13 lines
Signed-off-by Andre McCurdy <[email protected]>--- meta/recipes-core/systemd/systemd_232.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-core/systemd/systemd_232.bb +0
-0@@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"Quoted 5 lines
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 42
Quoted 1 line
meta/recipes-core/systemd/systemd_232.bb +1
-0+USE_LDCONFIG ?= "1"now that we have more recipes using this variables. I think it should to global config space. May be have it as a
DISTRO_FEATUREis more appropriatePatches for both approaches have now been sent to the list.
Quoted 15 lines
Quoted 15 lines
meta/recipes-core/systemd/systemd_232.bb +2
-2+ PACKAGECONFIG ??= "xz \ - ldconfig \ + ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \ --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 10 lines · Andre McCurdy
Quoted 4 lines · Andre McCurdy
Quoted 3 lines · Khem Raj
Quoted 2 lines · Andre McCurdy
Avoid trying to call ldconfig at run-time in distros which force
USE_LDCONFIGto 0 and therefore don't provide it.Ping.
Perhaps merge this simple patch first if there's no consensus on adding a distro config.
No, please ping the distro config patches instead.
Quoted 37 lines
Quoted 37 lines
Quoted 14 lines
Quoted 14 lines
Signed-off-by Andre McCurdy <[email protected]>--- meta/recipes-core/systemd/systemd_232.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)meta/recipes-core/systemd/systemd_232.bb +0
-0@@ -39,8 +39,10 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"Quoted 5 lines
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 42
Quoted 1 line
meta/recipes-core/systemd/systemd_232.bb +1
-0+USE_LDCONFIG ?= "1"now that we have more recipes using this variables. I think it should to global config space. May be have it as a
DISTRO_FEATUREis more appropriatePatches for both approaches have now been sent to the list.
Quoted 15 lines
Quoted 15 lines
meta/recipes-core/systemd/systemd_232.bb +2
-2+ PACKAGECONFIG ??= "xz \ - ldconfig \ + ${@base_conditional('USE_LDCONFIG', '1', 'ldconfig', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \ --1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core