Skip to contentSkip to conversation

Patch "drm/vc4: Fix memory leak of the CRTC state." has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 27, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/vc4: Fix memory leak of the CRTC state.

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-vc4-fix-memory-leak-of-the-crtc-state.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7622b25543665567d8830a63210385b7d705924b Mon Sep 17 00:00:00 2001

From: Eric Anholt <[email protected]>
Date: Mon, 10 Oct 2016 09:44:06 -0700
Subject: drm/vc4: Fix memory leak of the CRTC state.

From: Eric Anholt <[email protected]>

commit 7622b25543665567d8830a63210385b7d705924b upstream.

The underscores variant frees the pointers inside, while the no-underscores variant calls underscores and then frees the struct.

Fixes d8dbf44f13b9 ("drm/vc4: Make the CRTCs cooperate on allocating display lists.")
---
 drivers/gpu/drm/vc4/vc4_crtc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_crtc.c +1 -1
@@ -832,7 +832,7 @@ static void vc4_crtc_destroy_state(struc
 
 	}
 
-	__drm_atomic_helper_crtc_destroy_state(state);
+	drm_atomic_helper_crtc_destroy_state(crtc, state);
 }
 
 static const struct drm_crtc_funcs vc4_crtc_funcs = {

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/drm-vc4-return-einval-on-the-overflow-checks-failing.patch queue-4.9/drm-vc4-fix-memory-leak-of-the-crtc-state.patch queue-4.9/drm-vc4-fix-an-integer-overflow-in-temporary-allocation-layout.patch queue-4.9/drm-vc4-fix-a-bounds-check.patch