regulator: arizona-ldo1: constify regulator_ops structure
PATCH 1/1 regulator: arizona-ldo1: constify regulator_ops structure
Declare regulator_ops structure as const as it is only stored in the ops field of a regulator_desc structure. This field is of type const, so regulator_ops structures having this property can be made const too.
File size before: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
File size after: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
--- drivers/regulator/arizona-ldo1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/arizona-ldo1.c +2 -2
@@ -109,7 +109,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev)return (val &ARIZONA_LDO1_VSEL_MASK ) >>ARIZONA_LDO1_VSEL_SHIFT ; } -static struct regulator_ops arizona_ldo1_hc_ops = { +static const struct regulator_ops arizona_ldo1_hc_ops = { .list_voltage = arizona_ldo1_hc_list_voltage, .map_voltage = arizona_ldo1_hc_map_voltage, .get_voltage_sel = arizona_ldo1_hc_get_voltage_sel,
@@ -135,7 +135,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev) .owner = THIS_MODULE, }; -static struct regulator_ops arizona_ldo1_ops = { +static const struct regulator_ops arizona_ldo1_ops = { .list_voltage = regulator_list_voltage_linear, .map_voltage = regulator_map_voltage_linear, .get_voltage_sel = regulator_get_voltage_sel_regmap,
Signature · 1 line
1.9.1
Mark Brown
maintainerApplied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree
The patch
regulator: arizona-ldo1: constify regulator_ops structure
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
03d06107f834db328da5579348524855f10a276dMon Sep 17 00:00:00 2001
From: Bhumika Goyal <[email protected]>
Date: Sat, 28 Jan 2017 19:08:41 +0530
Subject: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure
Declare regulator_ops structure as const as it is only stored in the ops field of a regulator_desc structure. This field is of type const, so regulator_ops structures having this property can be made const too.
File size before: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
File size after: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
--- drivers/regulator/arizona-ldo1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/arizona-ldo1.c +2 -2
@@ -109,7 +109,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev)return (val &ARIZONA_LDO1_VSEL_MASK ) >>ARIZONA_LDO1_VSEL_SHIFT ; } -static struct regulator_ops arizona_ldo1_hc_ops = { +static const struct regulator_ops arizona_ldo1_hc_ops = { .list_voltage = arizona_ldo1_hc_list_voltage, .map_voltage = arizona_ldo1_hc_map_voltage, .get_voltage_sel = arizona_ldo1_hc_get_voltage_sel,
@@ -135,7 +135,7 @@ static const struct regulator_desc arizona_ldo1_hc = { .owner = THIS_MODULE, }; -static struct regulator_ops arizona_ldo1_ops = { +static const struct regulator_ops arizona_ldo1_ops = { .list_voltage = regulator_list_voltage_linear, .map_voltage = regulator_map_voltage_linear, .get_voltage_sel = regulator_get_voltage_sel_regmap,
Signature · 1 line
2.11.0
Quoted 8 lines · Bhumika Goyal
Declare
regulator_opsstructure as const as it is only stored in the ops field of aregulator_descstructure. This field is of type const, soregulator_opsstructures having this property can be made const too.File size before:
drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
1890 720 0 2610 a32drivers/regulator/arizona-ldo1.o
Quoted 6 lines
File size after:
drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
2402 192 0 2594 a22drivers/regulator/arizona-ldo1.oSigned-off-by Bhumika Goyal <[email protected]>---
Patch looks fine but CCing [email protected] on patches to the Arizona driver would be greatly appreciated.
Thanks,
Charles