Skip to contentSkip to conversation

regulator: pcap-regulator: constify regulator_ops structure

PATCH In review Bhumika Goyal 2 participants 2 messages Jan 28, 2017 – Jan 31, 2017 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: pcap-regulator: constify regulator_ops structure

Declare regulator_ops structure as const as it is only stored in the ops field of a regulator_desc structure. This field is of type const, so regulator_ops structures having this property can be made const too.

File size before: drivers/regulator/pcap-regulator.o
text data bss dec hex filename
5503 564 0 6067 17b3 regulator/pcap-regulator.o

File size after: drivers/regulator/pcap-regulator.o
text data bss dec hex filename
5759 308 0 6067 17b3 regulator/pcap-regulator.o

---
 drivers/regulator/pcap-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/pcap-regulator.c +1 -1
index 9b16e61..79cb971 100644
@@ -210,7 +210,7 @@ static int pcap_regulator_is_enabled(struct regulator_dev *rdev)
 	return (tmp >> vreg->en) & 1;
 }
 
-static struct regulator_ops pcap_regulator_ops = {
+static const struct regulator_ops pcap_regulator_ops = {
 	.list_voltage	= regulator_list_voltage_table,
 	.set_voltage_sel = pcap_regulator_set_voltage_sel,
 	.get_voltage_sel = pcap_regulator_get_voltage_sel,
Signature · 1 line
1.9.1
maintainer
#1 lore raw

Applied "regulator: pcap-regulator: constify regulator_ops structure" to the regulator tree

The patch

regulator: pcap-regulator: constify regulator_ops structure

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 00804e6af96b4072eafb25337936532738dd537f Mon Sep 17 00:00:00 2001

From: Bhumika Goyal <[email protected]>
Date: Sat, 28 Jan 2017 20:27:15 +0530
Subject: [PATCH] regulator: pcap-regulator: constify regulator_ops structure

Declare regulator_ops structure as const as it is only stored in the ops field of a regulator_desc structure. This field is of type const, so regulator_ops structures having this property can be made const too.

File size before: drivers/regulator/pcap-regulator.o
text data bss dec hex filename
5503 564 0 6067 17b3 regulator/pcap-regulator.o

File size after: drivers/regulator/pcap-regulator.o
text data bss dec hex filename
5759 308 0 6067 17b3 regulator/pcap-regulator.o

---
 drivers/regulator/pcap-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/pcap-regulator.c +1 -1
index 9b16e6158f15..79cb971a69bb 100644
@@ -210,7 +210,7 @@ static int pcap_regulator_is_enabled(struct regulator_dev *rdev)
 	return (tmp >> vreg->en) & 1;
 }
 
-static struct regulator_ops pcap_regulator_ops = {
+static const struct regulator_ops pcap_regulator_ops = {
 	.list_voltage	= regulator_list_voltage_table,
 	.set_voltage_sel = pcap_regulator_set_voltage_sel,
 	.get_voltage_sel = pcap_regulator_get_voltage_sel,
Signature · 1 line
2.11.0