WTF: patch "[PATCH] mmc: dw_mmc: force setup bus if active slots exist" was seriously submitted to be applied to the 4.9-stable tree?

From e9748e0364fe82dc037d22900ff13a62d04518bf Mon Sep 17 00:00:00 2001

The patch below was submitted to be applied to the 4.9-stable tree.

I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable_kernel_rules.rst.

I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From e9748e0364fe82dc037d22900ff13a62d04518bf Mon Sep 17 00:00:00 2001

From: Ziyuan Xu <[email protected]>
Date: Tue, 17 Jan 2017 09:22:56 +0800
Subject: [PATCH] mmc: dw_mmc: force setup bus if active slots exist

It's necessary to setup bus if any slots are present.
- update clock after ctrl reset
- if the host has genpd node, we can guarantee the clock is available before starting request. Otherwies, the clock register is reset once power off the pd, and host can't output the active clock during communication.

Fixes e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback")

Fixes df9bcc2bc0a1 ("mmc: dw_mmc: add missing codes for runtime resume")

cc <[email protected]>

Reported-by Randy Li <[email protected]>

Reported-by S. Gilles <[email protected]>

Signed-off-by Ziyuan Xu <[email protected]>

Signed-off-by Shawn Lin <[email protected]>

Signed-off-by Ulf Hansson <[email protected]>

drivers/mmc/host/dw_mmc.c +4 -3

index b44306b886cb..73db08558e4d 100644
@@ -3354,10 +3354,11 @@ int dw_mci_runtime_resume(struct device *dev)
 
  		if (!slot)
  			continue;
-		if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER) {
+		if (slot->mmc->pm_flags & MMC_PM_KEEP_POWER)
  			dw_mci_set_ios(slot->mmc, &slot->mmc->ios);
-			dw_mci_setup_bus(slot, true);
-		}
+
+		/* Force setup bus to guarantee available clock output */
+		dw_mci_setup_bus(slot, true);
  	}
 
  	/* Now that slots are all setup, we can enable card detect */