drm/i915: Drop unused engine parameter from i915_gem_validate_context
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Drop unused engine parameter from i915_gem_validate_context
From: Tvrtko Ursulin <[email protected]>
--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 -2
@@ -1233,7 +1233,7 @@ validate_exec_list(struct drm_device *dev,static struct i915_gem_context *i915_gem_validate_context (struct drm_device *dev,struct drm_file *file, -struct intel_engine_cs *engine,const u32 ctx_id) +const u32 ctx_id) {struct i915_gem_context *ctx;
@@ -1708,7 +1708,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,if (ret) goto pre_mutex_err; - ctx =i915_gem_validate_context (dev, file, engine, ctx_id); + ctx =i915_gem_validate_context (dev, file, ctx_id);if (IS_ERR (ctx)) {mutex_unlock (&dev->struct_mutex); ret =PTR_ERR (ctx);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 21 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_gem_execbuffer.c +1
-1@@ -1233,7 +1233,7 @@ validate_exec_list(struct drm_device *dev,static struct i915_gem_context *i915_gem_validate_context (struct drm_device *dev,struct drm_file *file, -struct intel_engine_cs *engine,const u32 ctx_id) +const u32 ctx_id) {struct i915_gem_context *ctx;
drivers/gpu/drm/i915/i915_gem_execbuffer.c i915_gem_do_execbuffer(struct drm_device *dev, void *data, · line 1713
Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_execbuffer.c +1
-1@@ -1708,7 +1708,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,if (ret) goto pre_mutex_err; - ctx =i915_gem_validate_context (dev, file, engine, ctx_id); + ctx =i915_gem_validate_context (dev, file, ctx_id);if (IS_ERR (ctx)) {mutex_unlock (&dev->struct_mutex);
static int eb_select_context(struct i915_execbuffer *eb)
{
struct i915_gem_context *ctx;
ctx = i915_gem_context_lookup(eb->file->driver_priv, eb->args->rsvd1);
if (unlikely(IS_ERR(ctx)))
return PTR_ERR(ctx);
if (unlikely(i915_gem_context_is_banned(ctx))) {
DRM_DEBUG("Context %u tried to submit while banned\n",
ctx->user_handle);
return -EIO;
}
eb->ctx = i915_gem_context_get(ctx);
eb->vm = ctx->ppgtt ? &ctx->ppgtt->base : &eb->i915->ggtt.base;
eb->context_flags = 0;
if (ctx->flags & CONTEXT_NO_ZEROMAP)
eb->context_flags |= __EXEC_OBJECT_NEEDS_BIAS;
return 0;
}Too soon?
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson
Reviewed-byQuoted 4 lines · Chris Wilson
Quoted 3 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Signed-off-by Tvrtko Ursulin <[email protected]>
Anyway, regardless of my jibe,
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Drop unused engine parameter from i915_gem_validate_context
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Drop unused engine parameter from i915_gem_validate_context
URL : https://patchwork.freedesktop.org/series/18781/
State : success
== Summary ==
Series 18781v1 drm/i915: Drop unused engine parameter from i915_gem_validate_context
https://patchwork.freedesktop.org/api/1.0/series/18781/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (fi-snb-2520m)
Test kms_force_connector_basic:
Subgroup force-connector-state:
dmesg-warn -> PASS (fi-snb-2520m)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
dmesg-warn -> PASS (fi-snb-2520m)fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-bxt-t5700 total:78 pass:65 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21 fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21 fi-kbl-7500u total:246 pass:223 dwarn:0 dfail:0 fail:2 skip:21 fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20 fi-skl-6700k total:246 pass:221 dwarn:4 dfail:0 fail:0 skip:21 fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-snb-2520m total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
123d798c350471aba7e0625c154c6d9e395756c8 drm-tip: 2017y-01m-30d-21h-14m-37s UTC integration manifest cea5fc4 drm/i915: Drop unused engine parameter from i915_gem_validate_context
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3645/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx