Skip to contentSkip to conversation

Patch "HID: cp2112: fix gpio-callback error handling" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 4, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

HID: cp2112: fix gpio-callback error handling

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hid-cp2112-fix-gpio-callback-error-handling.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8e9faa15469ed7c7467423db4c62aeed3ff4cae3 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 30 Jan 2017 11:26:39 +0100
Subject: HID: cp2112: fix gpio-callback error handling

From: Johan Hovold <[email protected]>

commit 8e9faa15469ed7c7467423db4c62aeed3ff4cae3 upstream.

In case of a zero-length report, the gpio direction_input callback would currently return success instead of an errno.

Fixes 1ffb3c40ffb5 ("HID: cp2112: make transfer buffers DMA capable")
---
 drivers/hid/hid-cp2112.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-cp2112.c +1 -1
@@ -206,7 +206,7 @@ static int cp2112_gpio_direction_input(s
 
 exit:
 	mutex_unlock(&dev->lock);
-	return ret <= 0 ? ret : -EIO;
+	return ret < 0 ? ret : -EIO;
 }
 
 static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/hid-cp2112-fix-gpio-callback-error-handling.patch queue-4.9/hid-cp2112-fix-sleep-while-atomic.patch