Patch "pinctrl: baytrail: Debounce register is one per community" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
pinctrl: baytrail: Debounce register is one per community
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-baytrail-debounce-register-is-one-per-community.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
1b89970d81bbd52720fc64a3fe9572ee33588363Mon Sep 17 00:00:00 2001
From: Andy Shevchenko <[email protected]>
Date: Thu, 26 Jan 2017 19:24:08 +0200
Subject: pinctrl: baytrail: Debounce register is one per community
From: Andy Shevchenko <[email protected]>
commit 1b89970d81bbd52720fc64a3fe9572ee33588363 upstream.
Debounce value is set globally per community. Otherwise user will easily get a kernel crash when they start using the feature:
BUG: unable to handle kernel paging request at ffffc900003be000 IP: byt_gpio_dbg_show+0xa9/0x430
Make it clear in byt_gpio_reg().
Note that this fix just prevents kernel to crash, but doesn't make any difference to the existing logic. It means the last caller will win the trade and debounce value will be configured accordingly. The actual logic fix needs to be thought about and it's not as important as crash fix. That's why the latter goes separately and right now.
--- drivers/pinctrl/intel/pinctrl-baytrail.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/pinctrl/intel/pinctrl-baytrail.c +10 -3
@@ -731,16 +731,23 @@ static void __iomem *byt_gpio_reg(struct int reg) {struct byt_community *comm =byt_get_community (vg, offset); -u32 reg_offset =0 ; +u32 reg_offset;if (!comm)return NULL ; offset -= comm->pin_base; -if (reg ==BYT_INT_STAT_REG ) +switch (reg) { +case BYT_INT_STAT_REG : reg_offset = (offset /32 ) *4 ; -else +break ; +case BYT_DEBOUNCE_REG : + reg_offset =0 ; +break ; +default : reg_offset = comm->pad_map[offset] *16 ; +break ; + }return comm->reg_base + reg_offset + reg; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/pinctrl-baytrail-debounce-register-is-one-per-community.patch queue-4.9/pinctrl-intel-merrifield-add-missed-check-in-mrfld_config_set.patch