Skip to contentSkip to conversation

iio: fixed symbolic permission references 'S_IRUGO | S_IWUSR'

PATCH Jonathan Cameron 1 participant 1 message Feb 5, 2017 1 message not in the archive IIO

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jonathan Cameron

author maintainer
#1 lore raw
Quoted 4 lines · Artur Lorincz

Replaced the symbolic permission references S_IRUGO and S_IWUSR with their octal counterparts.

Signed-off-by Artur Lorincz <[email protected]>

Applied with a small change to the description to mention which driver we are dealing with.

Also, for IIO patches please cc linux-iio as now done.

Jonathan

Quoted 37 lines
---
 drivers/staging/iio/adc/ad7192.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/iio/adc/ad7192.c +4 -5
index 1fb68c0..4fc8588 100644
@@ -342,9 +342,9 @@ static int ad7192_setup(struct ad7192_state *st,
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
 			     in_voltage-voltage_scale_available,
-			     S_IRUGO, ad7192_show_scale_available, NULL, 0);
+			     0444, ad7192_show_scale_available, NULL, 0);
 
-static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
+static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
 		       ad7192_show_scale_available, NULL, 0);
 
 static ssize_t ad7192_show_ac_excitation(struct device *dev,

@@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
 	return ret ? ret : len;
 }
 
-static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(bridge_switch_en, 0644,
 		       ad7192_show_bridge_switch, ad7192_set,
 		       AD7192_REG_GPOCON);
 
-static IIO_DEVICE_ATTR(ac_excitation_en, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(ac_excitation_en, 0644,
 		       ad7192_show_ac_excitation, ad7192_set,
 		       AD7192_REG_MODE);
 
--

1.9.1