Skip to contentSkip to conversation

Patch "iio: health: max30100: fixed parenthesis around FIFO count check" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 5, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: health: max30100: fixed parenthesis around FIFO count check

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-health-max30100-fixed-parenthesis-around-fifo-count-check.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 828f84ee8f84710ea1818b3565add268bcb824c8 Mon Sep 17 00:00:00 2001

From: Matt Ranostay <[email protected]>
Date: Mon, 16 Jan 2017 18:04:18 -0800
Subject: iio: health: max30100: fixed parenthesis around FIFO count check

From: Matt Ranostay <[email protected]>

commit 828f84ee8f84710ea1818b3565add268bcb824c8 upstream.

FIFO was being read every sample after the "almost full" state was reached. This was due to an incorrect placement of the parenthesis in the while condition check.

Note - the fixes tag is not actually correct, but the fix in this patch would also be needed for it to function correctly so we'll go with that one. Backports should pick up both.

Fixes b74fccad7 ("iio: health: max30100: correct FIFO check condition")
---
 drivers/iio/health/max30100.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/health/max30100.c +1 -1
@@ -238,7 +238,7 @@ static irqreturn_t max30100_interrupt_ha
 
 	mutex_lock(&data->lock);
 
-	while (cnt || (cnt = max30100_fifo_count(data) > 0)) {
+	while (cnt || (cnt = max30100_fifo_count(data)) > 0) {
 		ret = max30100_read_measurement(data);
 		if (ret)
 			break;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/iio-health-max30100-fixed-parenthesis-around-fifo-count-check.patch