Skip to contentSkip to conversation

Patch "target: Use correct SCSI status during EXTENDED_COPY exception" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 10, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

target: Use correct SCSI status during EXTENDED_COPY exception

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
target-use-correct-scsi-status-during-extended_copy-exception.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0583c261e6325f392c1f7a1b9112e31298e1a4bd Mon Sep 17 00:00:00 2001

From: Nicholas Bellinger <[email protected]>
Date: Mon, 31 Oct 2016 00:54:40 -0700
Subject: target: Use correct SCSI status during EXTENDED_COPY exception

From: Nicholas Bellinger <[email protected]>

commit 0583c261e6325f392c1f7a1b9112e31298e1a4bd upstream.

This patch adds the missing target_complete_cmd() SCSI status parameter change in target_xcopy_do_work(), that was originally missing in commit 926317de33.

It correctly propigates up the correct SCSI status during EXTENDED_COPY exception cases, instead of always using the hardcoded SAM_STAT_CHECK_CONDITION from original code.

This is required for ESX host environments that expect to hit SAM_STAT_RESERVATION_CONFLICT for certain scenarios, and SAM_STAT_CHECK_CONDITION results in non-retriable status for these cases.

---
 drivers/target/target_core_xcopy.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_xcopy.c +1 -1
@@ -836,7 +836,7 @@ out:
 			" CHECK_CONDITION -> sending response\n", rc);
 		ec_cmd->scsi_status = SAM_STAT_CHECK_CONDITION;
 	}
-	target_complete_cmd(ec_cmd, SAM_STAT_CHECK_CONDITION);
+	target_complete_cmd(ec_cmd, ec_cmd->scsi_status);
 }
 
 sense_reason_t target_do_xcopy(struct se_cmd *se_cmd)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/target-fix-compare_and_write-ref-leak-for-non-good-status.patch queue-4.9/target-fix-multi-session-dynamic-se_node_acl-double-free-oops.patch queue-4.9/target-use-correct-scsi-status-during-extended_copy-exception.patch queue-4.9/ibmvscsis-add-sgl-limit.patch queue-4.9/target-don-t-bug_on-during-nodeacl-dynamic-explicit-conversion.patch queue-4.9/target-fix-early-transport_generic_handle_tmr-abort-scenario.patch