Staging: media: bcm2048: Fixed an error
Subsystems (2)
PATCH 1/1 Staging: media: bcm2048: Fixed an error
Fixed an error where the system was given a code in the form of decimal instead of octal.
--- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
@@ -300,7 +300,7 @@ struct bcm2048_device { };static int radio_nr =-1 ;/* radio device minor (-1 ==> auto assign) */ -module_param (radio_nr, int,0 ); +module_param (radio_nr, int,0000 );MODULE_PARM_DESC (radio_nr,"Minor number for radio device (-1 ==> auto assign)" );
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 2 lines · Ran Algawi
Fixed an error where the system was given a code in the form of decimal instead of octal.
It's not really an "error", right? Please be more descriptive of exactly what is going on here (hint, it's a coding style warning...)
thanks,
greg k-h
Hello Greg,
I apperaciate you taking the time to educate me.
Do you consider all checkpatch errors/warnnings/checks as code style fixes?
With regards,
Ran A.
A message that is not in the archive (sent off-list or not yet received): CAKg+OeRBUVwixkiWnS07=vYG3QHRUkuKxtRmZn5dGWQ0SZVRzA@mail.gmail.com
Greg Kroah-Hartman
maintainerQuoted 4 lines · Ran Algawi
Hello Greg,
First, I appreciate you taking the time to educate me. I used the checkpatch script on the file I fixed and he reported the line as an error. Do you consider all checkpatch warnings/error/checks as coding style fixes?
The ones that refer to coding style issues, yes, that is what they are. Sometimes the script points out other things that should be changed, like octal values which is not an error in this case, but rather a clarification.
And please turn html off in your email client, it gets rejected by the mailing lists :)
thanks,
greg k-h