checkpatch: add warning on invalid %p extensions
PATCH v3 1/1 checkpatch: add warning on invalid %p extensions
From: William Roberts <[email protected]>
The kernel supports %p extensions as documented in Documentation/printk-formats.txt. Warn on possibly improper use of non-extension characters.
One issue would be the usage of %pk when %pK should have been used. This has a side-effect of appearing to work alright, but does not respect the kptr_restrict setting as %pK does.
Sample output:
WARNING: Invalid vsprintf pointer extension '%pk'
+ printk(KERN_INFO "Could not allocate IRQ %d for PCI Applicom device. %pk\n", dev->irq, pci_get_class); // NOT OK
improved-by [email protected]
Signed-off-by William Roberts <[email protected]>
--- scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+)
scripts/checkpatch.pl +9 -0
@@ -6096,6 +6096,15 @@ sub process { "recursive locking is bad, do not use this ever.\n" . $herecurr); } + # check for vsprintf extension %p<foo> misuses + if ($line =~ /\b$logFunctions\s*\(.*$String/) { + my $format = get_quoted_string($line, $rawline); + if ($format =~ /(\%[\*\d\.]*p(?![\WFfSsBKRraEhMmIiUDdgVCbGN]).)/) { + WARN("VSPRINTF_POINTER_EXTENSION", + "Invalid vsprintf pointer extension '$1'\n" . $herecurr); + } + } + # check for lockdep_set_novalidate_class if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ || $line =~ /__lockdep_no_validate__\s*\)/ ) {
Signature · 1 line
2.7.4