Skip to contentSkip to conversation

selftest: remove result file log awkward checking

PATCH New Benjamin Esquivel 1 participant 1 message Feb 13, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftest: remove result file log awkward checking

because of the way that the test cases are looked in the results, the file logger is incompatible with extended implementations of the unittest runner.

as the xml runner extends the unittest runner, it shares the id() method which returns the full name of the test, not only the test function name. With that, a single check of the full name reviews at the same time the class name as well as the function name.

[YOCTO#11012]

---
 meta/lib/oeqa/utils/decorators.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
meta/lib/oeqa/utils/decorators.py +4 -3
index 25f9c54..d876896 100644
@@ -172,18 +172,19 @@ def LogResults(original_class):
 
         #check status of tests and record it
 
+        tcid = self.id()
         for (name, msg) in result.errors:
-            if (self._testMethodName == str(name).split(' ')[0]) and (class_name in str(name).split(' ')[1]):
+            if tcid == name.id():
                 local_log.results("Testcase "+str(test_case)+": ERROR")
                 local_log.results("Testcase "+str(test_case)+":\n"+msg)
                 passed = False
         for (name, msg) in result.failures:
-            if (self._testMethodName == str(name).split(' ')[0]) and (class_name in str(name).split(' ')[1]):
+            if tcid == name.id():
                 local_log.results("Testcase "+str(test_case)+": FAILED")
                 local_log.results("Testcase "+str(test_case)+":\n"+msg)
                 passed = False
         for (name, msg) in result.skipped:
-            if (self._testMethodName == str(name).split(' ')[0]) and (class_name in str(name).split(' ')[1]):
+            if tcid == name.id():
                 local_log.results("Testcase "+str(test_case)+": SKIPPED")
                 passed = False
         if passed:
Signature · 1 line
2.5.1