Skip to contentSkip to conversation

ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

PATCH Applied Lei YU 3 participants 5 messages Feb 14, 2017 – Feb 24, 2017

Subsystems (2)
lore
Share & tools
lore

Lei YU

author
#0 lore raw

PATCH 1/3 ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

Also add the reserved-memory node needed by the LPC control driver.

---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +22 -0
index c23627e..f47eb63 100644
@@ -19,6 +19,18 @@
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		flash_memory: region@94000000 {
+			no-map;
+			reg = <0x94000000 0x04000000>; /* 64M */
+		};
+	};
+
 };
 
 &fmc {
@@ -44,6 +56,16 @@
 	};
 };
 
+&lpc_ctrl {
+	status = "okay";
+	memory-region = <&flash_memory>;
+	flash = <&spi1>;
+};
+
+&mbox {
+	status = "okay";
+};
+
 &uart5 {
 	status = "okay";
 };
Signature · 1 line
1.9.1
#1 lore raw

Hi Lei,

Quoted 24 lines · Lei YU

Also add the reserved-memory node needed by the LPC control driver.

Quoted 1 line

---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++

 1 file changed, 22 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
index c23627e..f47eb63 100644
@@ -19,6 +19,18 @@
 >  	memory {
 >  		reg = <0x80000000 0x40000000>;
 >  	};
+
 > +	reserved-memory {
 > +		#address-cells = <1>;
 > +		#size-cells = <1>;

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts line 26

Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
+		ranges;

+

Quoted 2 lines
Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
+		flash_memory: region@94000000 {
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
+			no-map;

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts line 30

Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
+			reg = <0x94000000 0x04000000>; /* 64M */

So these values are also used in the zaius dts. Why are we reserving 64M 128M down from the top of the RAM address space? Is the top 64M meant to be reserved for anything as well? Why not reserve the top 64M?

Quoted 17 lines
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
+		};

Review

Quoted 1 line
(quoted diff) +1 -0
+	};

+
 };

 &fmc {

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +0 -0
@@ -44,6 +56,16 @@
 >  	};
  };


+&lpc_ctrl {

Quoted 3 lines
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +3 -0
+	status = "okay";
+	memory-region = <&flash_memory>;
+	flash = <&spi1>;
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +3 -0
+};
+
+&mbox {
Quoted 2 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	status = "okay";

+};

This looks fine.

Andrew

Quoted 4 lines

+
 &uart5 {

Quoted 1 line

  status = "okay";

 };

author
#2 lore raw

Hi Andrew,

Quoted 24 lines · Andrew Jeffery

Hi Lei,

Quoted 21 lines · Lei YU

Also add the reserved-memory node needed by the LPC control driver.

Quoted 1 line
---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
index c23627e..f47eb63 100644
@@ -19,6 +19,18 @@
 >     memory {
 >             reg = <0x80000000 0x40000000>;
 >     };
+
 > +   reserved-memory {
 > +           #address-cells = <1>;
 > +           #size-cells = <1>;
Quoted 1 line

+ ranges;

Quoted 9 lines
Quoted 4 lines

+

Quoted 2 lines
Quoted 1 line

+ flash_memory: region@94000000 {

+ no-map;

+ reg = <0x94000000 0x04000000>; /* 64M */

So these values are also used in the zaius dts. Why are we reserving 64M 128M down from the top of the RAM address space? Is the top 64M meant to be reserved for anything as well? Why not reserve the top 64M?

This is a good question, but honestly I just copied this part from Witherspoon, and this is just the same as Zaius.
Maybe Joel has some comments on this?

Quoted 27 lines
Quoted 18 lines

+ };

Quoted 1 line

+ };

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +5 -0
+
 };
 
 &fmc {
@@ -44,6 +56,16 @@
 >     };
 };
 
+&lpc_ctrl {
 > +   status = "okay";
 > +   memory-region = <&flash_memory>;
 > +   flash = <&spi1>;
+};
+
+&mbox {
Quoted 1 line

+ status = "okay";

Quoted 1 line

+};

This looks fine.

Andrew

Quoted 4 lines

+
&uart5 {

Quoted 1 line
    status = "okay";

};

maintainer
#3 lore raw
Quoted 35 lines · Mine

Hi Andrew,

Quoted 32 lines · Andrew Jeffery

Hi Lei,

Quoted 21 lines · Lei YU

Also add the reserved-memory node needed by the LPC control driver.

Quoted 1 line
---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +1 -0
index c23627e..f47eb63 100644
@@ -19,6 +19,18 @@
 >     memory {
 >             reg = <0x80000000 0x40000000>;
 >     };
+
 > +   reserved-memory {
 > +           #address-cells = <1>;
 > +           #size-cells = <1>;
Quoted 1 line

+ ranges;

Quoted 4 lines

+

Quoted 2 lines
Quoted 1 line

+ flash_memory: region@94000000 {

+ no-map;

+ reg = <0x94000000 0x04000000>; /* 64M */

So these values are also used in the zaius dts. Why are we reserving 64M 128M down from the top of the RAM address space? Is the top 64M meant to be reserved for anything as well? Why not reserve the top 64M?

The top 64MB is for the host VGA framebuffer.

$ python3 -c "print(((0x80000000 + 0x40000000) - (0x94000000 +
0x04000000)) /1024./1024.)"
640.0

There was a mistake made due to not knowing the size of Zaius' DRAM, so things are 512MB lower than they should be.

Quoted 4 lines

This is a good question, but honestly I just copied this part from Witherspoon, and this is just the same as Zaius.

Maybe Joel has some comments on this?

The intent was to leave a 64MB window for the host framebuffer, and then put the 64MB buffer for mbox below.

Can you please fix up this patch and also send one to fix Zaius?

Cheers,

Joel

maintainer
#4 lore raw
In reply to Lei YU

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts line 68

Quoted 10 lines · Lei YU

+&lpc_ctrl {

arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +9 -0
+       status = "okay";
+       memory-region = <&flash_memory>;
+       flash = <&spi1>;
+};
+
+&mbox {
+       status = "okay";
+};
+

Lei,

I applied this part of the patch as the other part was applied as part of "ARM: dts: aspeed: Reserve RAM on P9 machines".

Cheers,

Joel