Skip to contentSkip to conversation

Patch "igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
igmp-mld-fix-memory-leak-in-igmpv3-mld_del_delrec.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Tue Feb 14 17:03:08 PST 2017

From: Hangbin Liu <[email protected]>
Date: Wed, 8 Feb 2017 21:16:45 +0800
Subject: igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()

From: Hangbin Liu <[email protected]>

[ Upstream commit 9c8bb163ae784be4f79ae504e78c862806087c54 ]

In function igmpv3/mld_add_delrec() we allocate pmc and put it in idev->mc_tomb, so we should free it when we don't need it in del_delrec(). But I removed kfree(pmc) incorrectly in latest two patches. Now fix it.

Fixes 24803f38a5c0 ("igmp: do not remove igmp souce list info when ...")
Fixes 1666d49e1d41 ("mld: do not remove mld souce list info when ...")
---
 net/ipv4/igmp.c  |    1 +
 net/ipv6/mcast.c |    1 +
 2 files changed, 2 insertions(+)
net/ipv4/igmp.c +1 -0
@@ -1172,6 +1172,7 @@ static void igmpv3_del_delrec(struct in_
 				psf->sf_crcount = im->crcount;
 		}
 		in_dev_put(pmc->interface);
+		kfree(pmc);
 	}
 	spin_unlock_bh(&im->lock);
 }
net/ipv6/mcast.c +1 -0
@@ -779,6 +779,7 @@ static void mld_del_delrec(struct inet6_
 				psf->sf_crcount = im->mca_crcount;
 		}
 		in6_dev_put(pmc->idev);
+		kfree(pmc);
 	}
 	spin_unlock_bh(&im->mca_lock);
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/igmp-mld-fix-memory-leak-in-igmpv3-mld_del_delrec.patch queue-4.9/mld-do-not-remove-mld-souce-list-info-when-set-link-down.patch