Skip to contentSkip to conversation

Patch "vfs: fix uninitialized flags in splice_to_pipe()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 20, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

vfs: fix uninitialized flags in splice_to_pipe()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
vfs-fix-uninitialized-flags-in-splice_to_pipe.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5a81e6a171cdbd1fa8bc1fdd80c23d3d71816fac Mon Sep 17 00:00:00 2001

From: Miklos Szeredi <[email protected]>
Date: Thu, 16 Feb 2017 17:49:02 +0100
Subject: vfs: fix uninitialized flags in splice_to_pipe()

From: Miklos Szeredi <[email protected]>

commit 5a81e6a171cdbd1fa8bc1fdd80c23d3d71816fac upstream.

Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused part of the pipe ring buffer. Previously splice_to_pipe() left the flags value alone, which could result in incorrect behavior.

Uninitialized flags appears to have been there from the introduction of the splice syscall.

---
 fs/splice.c |    1 +
 1 file changed, 1 insertion(+)
fs/splice.c +1 -0
@@ -211,6 +211,7 @@ ssize_t splice_to_pipe(struct pipe_inode
 			buf->len = spd->partial[page_nr].len;
 			buf->private = spd->partial[page_nr].private;
 			buf->ops = spd->ops;
+			buf->flags = 0;
 			if (spd->flags & SPLICE_F_GIFT)
 				buf->flags |= PIPE_BUF_FLAG_GIFT;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/vfs-fix-uninitialized-flags-in-splice_to_pipe.patch queue-4.4/fuse-fix-use-after-free-issue-in-fuse_dev_do_read.patch