Skip to contentSkip to conversation

Patch "NTB: ntb_transport: fix debugfs_remove_recursive" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 20, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

NTB: ntb_transport: fix debugfs_remove_recursive

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ntb-ntb_transport-fix-debugfs_remove_recursive.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dd62245e73de9138333cb0e7a42c8bc1215c3ce6 Mon Sep 17 00:00:00 2001

From: Allen Hubbe <[email protected]>
Date: Tue, 27 Dec 2016 17:57:04 -0500
Subject: NTB: ntb_transport: fix debugfs_remove_recursive

From: Allen Hubbe <[email protected]>

commit dd62245e73de9138333cb0e7a42c8bc1215c3ce6 upstream.

The call to debugfs_remove_recursive(qp->debugfs_dir) of the sub-level directory must not be later than debugfs_remove_recursive(nt_debugfs_dir) of the top-level directory. Otherwise, the sub-level directory will not exist, and it would be invalid (panic) to attempt to remove it. This removes the top-level directory last, after sub-level directories have been cleaned up.

Fixes e26a5843f ("NTB: Split ntb_hw_intel and ntb_transport drivers")
---
 drivers/ntb/ntb_transport.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/ntb/ntb_transport.c +1 -2
@@ -2270,9 +2270,8 @@ module_init(ntb_transport_init);
 
 static void __exit ntb_transport_exit(void)
 {
-	debugfs_remove_recursive(nt_debugfs_dir);
-
 	ntb_unregister_client(&ntb_transport_client);
 	bus_unregister(&ntb_transport_bus);
+	debugfs_remove_recursive(nt_debugfs_dir);
 }
 module_exit(ntb_transport_exit);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ntb-ntb_transport-fix-debugfs_remove_recursive.patch queue-4.9/ntb_transport-pick-an-unused-queue.patch