Skip to contentSkip to conversation

tracing: Fix code comment for ftrace_ops_get_func

PATCH Applied Chunyu Hu 2 participants 2 messages Feb 22, 2017 – Feb 27, 2017

Subsystems (2)
lore
Share & tools
lore

Chunyu Hu

author
#0 lore raw

PATCH 1/1 tracing: Fix code comment for ftrace_ops_get_func

There is no function 'ftrace_ops_recurs_func' existing in the code, it should be ftrace_ops_assist_func. Fix the comment to avoid misleading.

---
 kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/ftrace.c +1 -1
index 0c06093..fd84f2e 100644
@@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
  * Normally the mcount trampoline will call the ops->func, but there
  * are times that it should not. For example, if the ops does not
  * have its own recursion protection, then it should call the
- * ftrace_ops_recurs_func() instead.
+ * ftrace_ops_assist_func() instead.
  *
  * Returns the function that the trampoline should call for @ops.
  */
Signature · 1 line
1.8.3.1
maintainer Applied
#1 lore raw
Quoted 2 lines · On Wed, 22 Feb 2017 08:29:26 +0800 Chunyu Hu <[email protected]> wrote:

There is no function 'ftrace_ops_recurs_func' existing in the code, it should be ftrace_ops_assist_func. Fix the comment to avoid misleading.

Applied, thanks!

I'm not sure it will go in this merge window. It might, I'll have to see what else there is.

-- Steve

Quoted 19 lines
---
 kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/ftrace.c +1 -1
index 0c06093..fd84f2e 100644
@@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
  * Normally the mcount trampoline will call the ops->func, but there
  * are times that it should not. For example, if the ops does not
  * have its own recursion protection, then it should call the
- * ftrace_ops_recurs_func() instead.
+ * ftrace_ops_assist_func() instead.
  *
  * Returns the function that the trampoline should call for @ops.
  */