staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.
Subsystems (2)
PATCH 1/1 staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.
Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file.
--- .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c +8 -8
@@ -33,27 +33,27 @@#include "vchiq_build_info.h" #include <linux/broadcom/vc_debug_sym.h> -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_hostname,"dc4-arm-01" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_time, __TIME__ ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_date, __DATE__ ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_hostname,"dc4-arm-01" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_time, __TIME__); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_date, __DATE__); -const char *vchiq_get_build_hostname (void ) +const char *vchiq_get_build_hostname (void ) {return vchiq_build_hostname; } -const char *vchiq_get_build_version (void ) +const char *vchiq_get_build_version (void ) {return vchiq_build_version; } -const char *vchiq_get_build_date (void ) +const char *vchiq_get_build_date (void ) {return vchiq_build_date; } -const char *vchiq_get_build_time (void ) +const char *vchiq_get_build_time (void ) {return vchiq_build_time; }
Signature · 1 line
2.1.4
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
Quoted 8 lines · Yamanappagouda Patil
Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in
vchiq_version.cfile.Signed-off-by Yamanappagouda Patil <[email protected]>--- .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c +0
-0
[]
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c line 39
Quoted 12 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c +4
-4@@ -33,27 +33,27 @@#include "vchiq_build_info.h" #include <linux/broadcom/vc_debug_sym.h> -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_hostname,"dc4-arm-01" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_time, __TIME__ ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_date, __DATE__ ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_hostname,"dc4-arm-01" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_time, __TIME__); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_date, __DATE__);
Uses of __TIME__ and __DATE__ make it
impossible to have repeatable builds.
Are these __TIME__ and __DATE__ uses
really useful and necessary?
Greg KH
maintainerQuoted 26 lines · Joe Perches
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
Quoted 8 lines · Yamanappagouda Patil
Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in
vchiq_version.cfile.Signed-off-by Yamanappagouda Patil <[email protected]>--- .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c +0
-0[]
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c line 39
Quoted 12 lines
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c +4
-4@@ -33,27 +33,27 @@#include "vchiq_build_info.h" #include <linux/broadcom/vc_debug_sym.h> -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_hostname,"dc4-arm-01" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_time, __TIME__ ); -VC_DEBUG_DECLARE_STRING_VAR ( vchiq_build_date, __DATE__ ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_hostname,"dc4-arm-01" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_version,"9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_time, __TIME__); +VC_DEBUG_DECLARE_STRING_VAR (vchiq_build_date, __DATE__);Uses of
__TIME__and__DATE__make it
impossible to have repeatable builds.
Quoted 2 lines
Are these
__TIME__and__DATE__uses
really useful and necessary?
No, they need to be removed, but not in this patch :)
thanks,
greg k-h