Skip to contentSkip to conversation

Patch "USB: serial: opticon: fix CTS retrieval at open" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 23, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: opticon: fix CTS retrieval at open

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-opticon-fix-cts-retrieval-at-open.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2eee05020a0e7ee7c04422cbacdb07859e45dce6 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Fri, 13 Jan 2017 13:21:08 +0100
Subject: USB: serial: opticon: fix CTS retrieval at open

From: Johan Hovold <[email protected]>

commit 2eee05020a0e7ee7c04422cbacdb07859e45dce6 upstream.

The opticon driver used a control request at open to trigger a CTS status notification to be sent over the bulk-in pipe. When the driver was converted to using the generic read implementation, an inverted test prevented this request from being sent, something which could lead to TIOCMGET reporting an incorrect CTS state.

Fixes 7a6ee2b02751 ("USB: opticon: switch to generic read implementation")
---
 drivers/usb/serial/opticon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/opticon.c +1 -1
@@ -142,7 +142,7 @@ static int opticon_open(struct tty_struc
 	usb_clear_halt(port->serial->dev, port->read_urb->pipe);
 
 	res = usb_serial_generic_open(tty, port);
-	if (!res)
+	if (res)
 		return res;
 
 	/* Request CTS line state, sometimes during opening the current

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-ftdi_sio-fix-modem-status-error-handling.patch queue-4.4/usb-serial-cp210x-add-new-ids-for-ge-bx50v3-boards.patch queue-4.4/usb-serial-ark3116-fix-register-accessor-error-handling.patch queue-4.4/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch queue-4.4/usb-serial-ftdi_sio-fix-line-status-over-reporting.patch queue-4.4/usb-serial-ftdi_sio-fix-extreme-low-latency-setting.patch queue-4.4/usb-serial-spcp8x5-fix-modem-status-handling.patch queue-4.4/usb-serial-opticon-fix-cts-retrieval-at-open.patch queue-4.4/usb-serial-mos7840-fix-another-null-deref-at-open.patch