process: stop bb.process.communicate mixing bytes and str return types
PATCH 1/1 process: stop bb.process.communicate mixing bytes and str return types
Python3 regards b"" as False so it is not being converted to a string by d0f904d407f57998419bd9c305ce53e5eaa36b24. This confusingly causes three different potential types for each member of the returned tuple.
Let's just assume that everything that's not None is a bytes object and convert it to a string.
Signed-off-by Mike Crowe <[email protected]>
--- lib/bb/process.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/bb/process.py +2 -2
@@ -162,9 +162,9 @@ def run(cmd, input=None, log=None, extrafiles=None, **options): stdout, stderr = _logged_communicate(pipe, log, input, extrafiles) else: stdout, stderr = pipe.communicate(input) - if stdout: + if not stdout is None: stdout = stdout.decode("utf-8") - if stderr: + if not stderr is None: stderr = stderr.decode("utf-8") if pipe.returncode != 0:
Signature · 1 line
2.1.4