Skip to contentSkip to conversation

tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

PATCH New Timur Tabi 3 participants 6 messages Feb 28, 2017

Subsystems (2)
lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

---
 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/spcr.c +1 -1
index 2b5d0fa..2051a8c 100644
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
 		return true;
 
 	if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
-			h->oem_revision == 0)
+			h->oem_revision == 1)
 		return true;
 
 	return false;
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

drivers/acpi/spcr.c static bool qdf2400_erratum_44_present(struct · line 34

Quoted 12 lines
drivers/acpi/spcr.c +1 -1
@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct
 acpi_table_header *h)
 		return true;
 
 	if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
-			h->oem_revision == 0)
+			h->oem_revision == 1)

You might want to make this <= 1 and also change firmware to 0 so that new firmware with old kernels, new kernels with old firmware, and new kernels with new firmware all get the workaround applied.

Regards,
Cov

Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
author
#2 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 3 lines · Christopher Covington

You might want to make this <= 1 and also change firmware to 0 so that new firmware with old kernels, new kernels with old firmware, and new kernels with new firmware all get the workaround applied.

I thought about that, but there is apparently no firmware that sets the value to 0.

Signature · 3 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
#3 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

In reply to Timur Tabi
Quoted 3 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm QDF2400 and QDF2432")' ?

-dann

author
#4 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 7 lines · dann frazier
Quoted 3 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm QDF2400 and QDF2432")' ?

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")

I will post a v2.

Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
#5 lore raw

PATCH 1/1 tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Quoted 9 lines · Timur Tabi
Quoted 8 lines · dann frazier
Quoted 4 lines · Timur Tabi

For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0.

Quoted 5 lines
Quoted 2 lines

Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm QDF2400 and QDF2432")' ?

Fixes d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")

oops.. right. Pulled the long line from my git --grep QDF2400 :(

-dann

Quoted 7 lines

I will post a v2.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.