Skip to contentSkip to conversation

conf/machine/include: enable hardfloat by default for ARMv6 and above

PATCH Superseded Andre McCurdy 3 participants 9 messages Mar 6, 2017 – Mar 9, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 conf/machine/include: enable hardfloat by default for ARMv6 and above

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -1
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

I like this patch and want to clarify that it changes the default ISA to thumb2 which we should use anyway due to size reasons and other distros use it as default too.

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

Quoted 122 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -2
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 11 lines · Khem Raj
Quoted 6 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

I like this patch and want to clarify that it changes the default ISA to thumb2 which we should use anyway due to size reasons and other distros use it as default too.

No, it doesn't. The choice between ARM and Thumb(2) is made by the ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 122 lines
Quoted 122 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -2
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 20 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Quoted 6 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

I like this patch and want to clarify that it changes the default ISA to thumb2 which we should use anyway due to size reasons and other distros use it as default too.

No, it doesn't. The choice between ARM and Thumb(2) is made by the ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 5 lines
Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

Well, google does find a few examples, so to avoid any possible risk of somehow trying to use Thumb-1 I'll send a v2 which drops the 't' for ARMv6.

Quoted 125 lines

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 122 lines
Quoted 122 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -2
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
In reply to Andre McCurdy
Quoted 11 lines · Andre McCurdy
Quoted 1 line · Khem Raj

On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <[email protected]>

Quoted 5 lines · wrote:
Quoted 5 lines

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

Quoted 2 lines
Quoted 1 line
Quoted 7 lines
Quoted 1 line

I like this patch and want to clarify that it changes the default ISA to

thumb2

Quoted 1 line

which we should use anyway due to size reasons and other distros use it

as

Quoted 1 line

default too.

No, it doesn't.

That's right I wanted to say to make that default while you are at it

The choice between ARM and Thumb(2) is made by the

Quoted 148 lines

ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 14 lines
Quoted 14 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv6.inc

Quoted 10 lines

Review

Quoted 10 lines

index 91f0f07..5e1f973 100644

meta/conf/machine/include/arm/arch-armv6.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv7a.inc

Quoted 10 lines

Review

Quoted 10 lines

index 5446048..bad1c27 100644

meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv7ve.inc

Quoted 10 lines

Review

Quoted 10 lines

index 42d8d04..4d9260f 100644

meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-arm1136jf-s.inc

Quoted 10 lines

Review

Quoted 10 lines

index 53994ef..2cadbee 100644

meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa15.inc

Quoted 10 lines

Review

Quoted 10 lines

index 03de602..25e99f9 100644

meta/conf/machine/include/tune-cortexa15.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa17.inc

Quoted 10 lines

Review

Quoted 10 lines

index f659a62..40392f9 100644

meta/conf/machine/include/tune-cortexa17.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa5.inc

Quoted 10 lines

Review

Quoted 10 lines

index 93f9ca4..1f0cda6 100644

meta/conf/machine/include/tune-cortexa5.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa7.inc

Quoted 10 lines

Review

Quoted 10 lines

index 52e06b8..52415d9 100644

meta/conf/machine/include/tune-cortexa7.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa8.inc

Quoted 10 lines

Review

Quoted 10 lines

index a831bd5..8ee8de9 100644

meta/conf/machine/include/tune-cortexa8.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa9.inc

Quoted 17 lines
Quoted 17 lines

index 8b84e60..0cf323c 100644

meta/conf/machine/include/tune-cortexa9.inc +1 -2
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
--

1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw

Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213

Quoted 182 lines · Khem Raj
Quoted 11 lines · Andre McCurdy
Quoted 1 line · Khem Raj

On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <[email protected]>

Quoted 5 lines · wrote:
Quoted 5 lines

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-

February/034637.html

Quoted 2 lines
Quoted 1 line
Quoted 7 lines
Quoted 1 line

I like this patch and want to clarify that it changes the default ISA

to thumb2

Quoted 1 line

which we should use anyway due to size reasons and other distros use it

as

Quoted 1 line

default too.

No, it doesn't.

That's right I wanted to say to make that default while you are at it

The choice between ARM and Thumb(2) is made by the

Quoted 139 lines

ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 14 lines
Quoted 14 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv6.inc

Quoted 10 lines

Review

Quoted 10 lines

index 91f0f07..5e1f973 100644

meta/conf/machine/include/arm/arch-armv6.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv7a.inc

Quoted 10 lines

Review

Quoted 10 lines

index 5446048..bad1c27 100644

meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
(quoted diff) +0 -0

b/meta/conf/machine/include/arm/arch-armv7ve.inc

Quoted 10 lines

Review

Quoted 10 lines

index 42d8d04..4d9260f 100644

meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-arm1136jf-s.inc

Quoted 10 lines

Review

Quoted 10 lines

index 53994ef..2cadbee 100644

meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa15.inc

Quoted 10 lines

Review

Quoted 10 lines

index 03de602..25e99f9 100644

meta/conf/machine/include/tune-cortexa15.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa17.inc

Quoted 10 lines

Review

Quoted 10 lines

index f659a62..40392f9 100644

meta/conf/machine/include/tune-cortexa17.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa5.inc

Quoted 10 lines

Review

Quoted 10 lines

index 93f9ca4..1f0cda6 100644

meta/conf/machine/include/tune-cortexa5.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa7.inc

Quoted 10 lines

Review

Quoted 10 lines

index 52e06b8..52415d9 100644

meta/conf/machine/include/tune-cortexa7.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa8.inc

Quoted 10 lines

Review

Quoted 10 lines

index a831bd5..8ee8de9 100644

meta/conf/machine/include/tune-cortexa8.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa9.inc

Quoted 9 lines
Quoted 9 lines

index 8b84e60..0cf323c 100644

meta/conf/machine/include/tune-cortexa9.inc +1 -1
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#6 lore raw
Quoted 1 line · Martin Jansa

Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

Yes, that's the longer term goal. It needs to be done a little carefully though - ie in a way which doesn't ever enable Thumb by default for cores which only support Thumb1.

Quoted 186 lines

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213

Quoted 182 lines · Khem Raj
Quoted 12 lines · Andre McCurdy
Quoted 10 lines · Khem Raj
Quoted 7 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

Quoted 7 lines
Quoted 5 lines

I like this patch and want to clarify that it changes the default ISA to thumb2
which we should use anyway due to size reasons and other distros use it as
default too.

No, it doesn't.

That's right I wanted to say to make that default while you are at it

Quoted 140 lines

The choice between ARM and Thumb(2) is made by the ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 124 lines
Quoted 124 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -1
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw
Quoted 6 lines · Andre McCurdy
Quoted 1 line · Martin Jansa

Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

Yes, that's the longer term goal. It needs to be done a little carefully though - ie in a way which doesn't ever enable Thumb by default for cores which only support Thumb1.

Why carefully? If we assume that DISTRO maintainers will select DEFAULTTUNE correctly then we can assume that they will enable thumb only for MACHINEs which support Thumb2. I think it's smaller change for OE users than this already merged change of DEFAULTTUNEs.

And if they decide to use thumb also for qemuarm like I do in bitbake world builds, then it should work as well.

Quoted 186 lines
Quoted 186 lines

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213

Quoted 182 lines · Khem Raj
Quoted 12 lines · Andre McCurdy
Quoted 10 lines · Khem Raj
Quoted 7 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

Quoted 7 lines
Quoted 5 lines

I like this patch and want to clarify that it changes the default ISA to thumb2
which we should use anyway due to size reasons and other distros use it as
default too.

No, it doesn't.

That's right I wanted to say to make that default while you are at it

Quoted 140 lines

The choice between ARM and Thumb(2) is made by the ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 124 lines
Quoted 124 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -1
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#8 lore raw
Quoted 4 lines · Martin Jansa
Quoted 3 lines · Andre McCurdy
Quoted 1 line · Martin Jansa

Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

Quoted 8 lines
Quoted 3 lines

Yes, that's the longer term goal. It needs to be done a little carefully though - ie in a way which doesn't ever enable Thumb by default for cores which only support Thumb1.

Why carefully? If we assume that DISTRO maintainers will select DEFAULTTUNE correctly then we can assume that they will enable thumb only for MACHINEs which support Thumb2. I think it's smaller change for OE users than this already merged change of DEFAULTTUNEs.

I don't think you can assume that distro maintainers will set DEFAULTTUNE or ARM_INSTRUCTION_SET correctly (poky certainly doesn't) so the defaults in oe-core should be sensible (ie safe but reasonably up to date).

Quoted 2 lines

And if they decide to use thumb also for qemuarm like I do in bitbake world builds, then it should work as well.

Thumb1 is basically dead at this point. Even if it builds, who knows what runtime issues might show up. Enabling Thumb1 by default in oe-core is not something we should be doing (in my opinion anyway).

Quoted 189 lines
Quoted 172 lines
Quoted 172 lines

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213

Quoted 169 lines · Khem Raj
Quoted 12 lines · Andre McCurdy
Quoted 10 lines · Khem Raj
Quoted 7 lines · Andre McCurdy

Defaulting to softfp probably isn't the best choice anymore, especially as there are now ARM BSP layers which leave DEFAULTTUNE entirely up to the distro:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

Quoted 7 lines
Quoted 5 lines

I like this patch and want to clarify that it changes the default ISA to thumb2
which we should use anyway due to size reasons and other distros use it as
default too.

No, it doesn't.

That's right I wanted to say to make that default while you are at it

Quoted 143 lines

The choice between ARM and Thumb(2) is made by the ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means that the ARM_INSTRUCTION_SET variable will not be ignored (it's really a long standing bug that we ever defined DEFAULTTUNE options for ARMv6 and above which ignore ARM_INSTRUCTION_SET, but that's a separate topic).

Quoted 2 lines

I am not sure of we should change it for armv6 though. since some armv6 has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you have a reference?

(But again, to be clear, this commit doesn't change the default in terms of instruction set - all builds will still use ARM).

Quoted 127 lines
Quoted 127 lines
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
meta/conf/machine/include/arm/arch-armv6.inc +1 -1
index 91f0f07..5e1f973 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
meta/conf/machine/include/arm/arch-armv7a.inc +1 -1
index 5446048..bad1c27 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
meta/conf/machine/include/arm/arch-armv7ve.inc +1 -1
index 42d8d04..4d9260f 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
meta/conf/machine/include/tune-arm1136jf-s.inc +1 -1
index 53994ef..2cadbee 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
meta/conf/machine/include/tune-cortexa15.inc +1 -1
index 03de602..25e99f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa17.inc +1 -1
index f659a62..40392f9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa5.inc +1 -1
index 93f9ca4..1f0cda6 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa7.inc +1 -1
index 52e06b8..52415d9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
meta/conf/machine/include/tune-cortexa8.inc +1 -1
index a831bd5..8ee8de9 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
meta/conf/machine/include/tune-cortexa9.inc +1 -2
index 8b84e60..0cf323c 100644
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
--

1.9.1

Quoted 14 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Quoted 7 lines
Quoted 6 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
Martin 'JaMa' Jansa jabber: [email protected]