Skip to contentSkip to conversation

Patch "[media] lirc_dev: LIRC_{G,S}ET_REC_MODE do not work" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 8, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] lirc_dev: LIRC_{G,S}ET_REC_MODE do not work

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
lirc_dev-lirc_-g-s-et_rec_mode-do-not-work.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From bd291208d7f5d6b2d6a033fee449a429230b06df Mon Sep 17 00:00:00 2001

From: Sean Young <[email protected]>
Date: Fri, 2 Dec 2016 15:16:08 -0200
Subject: [media] lirc_dev: LIRC_{G,S}ET_REC_MODE do not work

From: Sean Young <[email protected]>

commit bd291208d7f5d6b2d6a033fee449a429230b06df upstream.

Since "273b902 [media] lirc_dev: use LIRC_CAN_REC() define" these ioctls no longer work.

---
 drivers/media/rc/lirc_dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/rc/lirc_dev.c +2 -2
@@ -582,7 +582,7 @@ long lirc_dev_fop_ioctl(struct file *fil
 		result = put_user(ir->d.features, (__u32 __user *)arg);
 		break;
 	case LIRC_GET_REC_MODE:
-		if (LIRC_CAN_REC(ir->d.features)) {
+		if (!LIRC_CAN_REC(ir->d.features)) {
 			result = -ENOTTY;
 			break;
 		}
@@ -592,7 +592,7 @@ long lirc_dev_fop_ioctl(struct file *fil
 				  (__u32 __user *)arg);
 		break;
 	case LIRC_SET_REC_MODE:
-		if (LIRC_CAN_REC(ir->d.features)) {
+		if (!LIRC_CAN_REC(ir->d.features)) {
 			result = -ENOTTY;
 			break;
 		}

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/lirc_dev-lirc_-g-s-et_rec_mode-do-not-work.patch