patch "USB: serial: digi_acceleport: fix OOB-event processing" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: digi_acceleport: fix OOB-event processing
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
2f6821462fe3ace62df3f1b5a9463153e8288298Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Fri, 24 Feb 2017 19:11:28 +0100
Subject: USB: serial: digi_acceleport: fix OOB-event processing
A recent change claimed to fix an off-by-one error in the OOB-port completion handler, but instead introduced such an error. This could specifically led to modem-status changes going unnoticed, effectively breaking TIOCMGET.
Note that the offending commit fixes a loop-condition underflow and is marked for stable, but should not be backported without this fix.
--- drivers/usb/serial/digi_acceleport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/digi_acceleport.c +1 -1
@@ -1500,7 +1500,7 @@ static int digi_read_oob_callback(struct urb *urb)return -1 ;/* handle each oob command */ -for (i =0 ; i < urb->actual_length -4 ; i +=4 ) { +for (i =0 ; i < urb->actual_length -3 ; i +=4 ) { opcode = buf[i]; line = buf[i +1 ]; status = buf[i +2 ];
Signature · 1 line
2.12.0