patch "USB: serial: io_ti: fix information leak in completion handler" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: io_ti: fix information leak in completion handler
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
654b404f2a222f918af9b0cd18ad469d0c941a8eMon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2017 17:36:40 +0100
Subject: USB: serial: io_ti: fix information leak in completion handler
Add missing sanity check to the bulk-in completion handler to avoid an integer underflow that can be triggered by a malicious device.
This avoids leaking 128 kB of memory content from after the URB transfer buffer to user space.
--- drivers/usb/serial/io_ti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/io_ti.c +1 -1
@@ -1761,7 +1761,7 @@ static void edge_bulk_in_callback(struct urb *urb) port_number = edge_port->port->port_number; -if (edge_port->lsr_event) { +if (urb->actual_length >0 && edge_port->lsr_event) { edge_port->lsr_event =0 ;dev_dbg (dev,"%s ===== Port %u LSR Status = %02x, Data = %02x ======\n" , __func__, port_number, edge_port->lsr_mask, *data);
Signature · 1 line
2.12.0