Minor coding guideline Fix in lusture module
PATCH 1/1 Minor coding guideline Fix in lusture module
Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id. Checkpath.pl passed.
--- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/lustre/lustre/llite/vvp_dev.c +4 -5
@@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)#define PGC_DEPTH_SHIFT (32)struct vvp_pgcache_id { -unsigned vpi_bucket; -unsigned vpi_depth; -uint32_t vpi_index; - -unsigned vpi_curdep; +unsigned int vpi_bucket; +unsigned int vpi_depth; +uint32_t vpi_index; +unsigned int vpi_curdep;struct lu_object_header *vpi_obj; };
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 30 lines · Pushkar Jambhlekar
Replacing 'unsigned' with 'unsigned int' in
vvp_pgcache_id. Checkpath.pl passed.Signed-off-by Pushkar Jambhlekar <[email protected]>--- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)drivers/staging/lustre/lustre/llite/vvp_dev.c +4
-5@@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)#define PGC_DEPTH_SHIFT (32)struct vvp_pgcache_id { -unsigned vpi_bucket; -unsigned vpi_depth; -uint32_t vpi_index; - -unsigned vpi_curdep; +unsigned int vpi_bucket; +unsigned int vpi_depth; +uint32_t vpi_index; +unsigned int vpi_curdep;struct lu_object_header *vpi_obj; };Signature · 1 line
2.7.4
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 1 line · Pushkar Jambhlekar
Subject: Minor coding guideline Fix in lusture module
I suspect the patchbot is unhappy with the subject line not containing anything useful, and not containing the subsystem name. Something like:
staging/lustre/llite: replace "unsigned" with "unsigned int"
Quoted 1 line
Replacing 'unsigned' with 'unsigned int' in
vvp_pgcache_id.
Remove double space, and reference function names like vvp_pgcache_id().
Quoted 1 line
Checkpath.pl passed.
"checkpatch.pl"
Cheers, Andreas
Quoted 28 lines
Signed-off-by Pushkar Jambhlekar <[email protected]>---
drivers/staging/lustre/lustre/llite/vvp_dev.c| 9 ++++-----1 file changed, 4 insertions(+), 5 deletions(-)drivers/staging/lustre/lustre/llite/vvp_dev.c +4
-5@@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb)#define PGC_DEPTH_SHIFT (32)struct vvp_pgcache_id { -unsigned vpi_bucket; -unsigned vpi_depth; -uint32_t vpi_index; - -unsigned vpi_curdep; +unsigned int vpi_bucket; +unsigned int vpi_depth; +uint32_t vpi_index; +unsigned int vpi_curdep;struct lu_object_header *vpi_obj; };Signature · 1 line
2.7.4
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation