Patch "RDMA/core: Fix incorrect structure packing for booleans" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled

RDMA/core: Fix incorrect structure packing for booleans

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rdma-core-fix-incorrect-structure-packing-for-booleans.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Jason Gunthorpe <[email protected]>
Date: Thu, 22 Dec 2016 18:07:52 -0700
Subject: RDMA/core: Fix incorrect structure packing for booleans

From: Jason Gunthorpe <[email protected]>

commit 55efcfcd7776165b294f8b5cd6e05ca00ec89b7c upstream.

The RDMA core uses ib_pack() to convert from unpacked CPU structs to on-the-wire bitpacked structs.

This process requires that 1 bit fields are declared as u8 in the unpacked struct, otherwise the packing process does not read the value properly and the packed result is wired to 0. Several places wrongly used int.

Crucially this means the kernel has never, set reversible correctly in the path record request. It has always asked for irreversible paths even if the ULP requests otherwise.

When the kernel is used with a SM that supports this feature, it completely breaks communication management if reversible paths are not properly requested.

The only reason this ever worked is because opensm ignores the reversible bit.

---
 include/rdma/ib_sa.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

@@ -138,12 +138,12 @@ struct ib_sa_path_rec {
 	union ib_gid sgid;
 	__be16       dlid;
 	__be16       slid;
-	int          raw_traffic;
+	u8           raw_traffic;
 	/* reserved */
 	__be32       flow_label;
 	u8           hop_limit;
 	u8           traffic_class;
-	int          reversible;
+	u8           reversible;
 	u8           numb_path;
 	__be16       pkey;
 	__be16       qos_class;

@@ -204,7 +204,7 @@ struct ib_sa_mcmember_rec {
 	u8           hop_limit;
 	u8           scope;
 	u8           join_state;
-	int          proxy_join;
+	u8           proxy_join;
 };
 
 /* Service Record Component Mask Sec 15.2.5.14 Ver 1.1	*/

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/rdma-core-fix-incorrect-structure-packing-for-booleans.patch