Patch "usb: gadget: udc: fsl: Add missing complete function." has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: fsl: Add missing complete function.
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-udc-fsl-add-missing-complete-function.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5528954a1a0c49c6974ef1b8d6eaceff536204d5Mon Sep 17 00:00:00 2001
From: Magnus Lilja <[email protected]>
Date: Wed, 25 Jan 2017 22:07:59 +0100
Subject: usb: gadget: udc: fsl: Add missing complete function.
From: Magnus Lilja <[email protected]>
commit 5528954a1a0c49c6974ef1b8d6eaceff536204d5 upstream.
Commit 304f7e5e1d08 ("usb: gadget: Refactor request completion") removed check if req->req.complete is non-NULL, resulting in a NULL pointer derefence and a kernel panic.
This patch adds an empty complete function instead of re-introducing the req->req.complete check.
--- drivers/usb/gadget/udc/fsl_udc_core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/fsl_udc_core.c +8 -2
@@ -1249,6 +1249,12 @@ static const struct usb_gadget_ops fsl_g .udc_stop = fsl_udc_stop, }; +/* +* Empty complete function used by this driver to fill in the req->complete +* field when creating a request since the complete field is mandatory. +*/ +static void fsl_noop_complete (struct usb_ep *ep,struct usb_request *req) { } +/* Set protocol stall on ep0, protocol stall will automatically be cleared on new transaction */ static void ep0stall (struct fsl_udc *udc)
@@ -1283,7 +1289,7 @@ static int ep0_prime_status(struct fsl_u req->req.length =0 ; req->req.status = -EINPROGRESS ; req->req.actual =0 ; - req->req.complete =NULL ; + req->req.complete = fsl_noop_complete; req->dtd_count =0 ; ret =usb_gadget_map_request (&ep->udc->gadget, &req->req,ep_is_in (ep));
@@ -1366,7 +1372,7 @@ static void ch9getstatus(struct fsl_udc req->req.length =2 ; req->req.status = -EINPROGRESS ; req->req.actual =0 ; - req->req.complete =NULL ; + req->req.complete = fsl_noop_complete; req->dtd_count =0 ; ret =usb_gadget_map_request (&ep->udc->gadget, &req->req,ep_is_in (ep));
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/dmaengine-ipu-make-sure-the-interrupt-routine-checks-all-interrupts.patch queue-4.4/usb-gadget-udc-fsl-add-missing-complete-function.patch