Skip to contentSkip to conversation

Patch "w1: don't leak refcount on slave attach failure in w1_attach_slave_device()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 10, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

w1: don't leak refcount on slave attach failure in w1_attach_slave_device()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
w1-don-t-leak-refcount-on-slave-attach-failure-in-w1_attach_slave_device.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a Mon Sep 17 00:00:00 2001

From: "Maciej S. Szmigiero" <[email protected]>
Date: Sat, 21 Jan 2017 23:50:18 +0100
Subject: w1: don't leak refcount on slave attach failure in w1_attach_slave_device()

From: Maciej S. Szmigiero <[email protected]>

commit d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a upstream.

Near the beginning of w1_attach_slave_device() we increment a w1 master reference count.
Later, when we are going to exit this function without actually attaching a slave device (due to failure of __w1_attach_slave_device()) we need to decrement this reference count back.

Fixes 9fcbbac5ded489 ("w1: process w1 netlink commands in w1_process thread")
Cc Evgeniy Polyakov <[email protected]>
---
 drivers/w1/w1.c |    1 +
 1 file changed, 1 insertion(+)
drivers/w1/w1.c +1 -0
@@ -763,6 +763,7 @@ int w1_attach_slave_device(struct w1_mas
 		dev_err(&dev->dev, "%s: Attaching %s failed.\n", __func__,
 			 sl->name);
 		w1_family_put(sl->family);
+		atomic_dec(&sl->master->refcnt);
 		kfree(sl);
 		return err;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/w1-don-t-leak-refcount-on-slave-attach-failure-in-w1_attach_slave_device.patch queue-4.4/w1-ds2490-usb-transfer-buffers-need-to-be-dmaable.patch