Patch "pNFS/flexfiles: If the layout is invalid, it must be updated before retrying" has been added to the 4.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
pNFS/flexfiles: If the layout is invalid, it must be updated before retrying
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pnfs-flexfiles-if-the-layout-is-invalid-it-must-be-updated-before-retrying.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
df3ab232e462bce20710596d697ade6b72497694Mon Sep 17 00:00:00 2001
From: Trond Myklebust <[email protected]>
Date: Fri, 17 Feb 2017 19:49:09 -0500
Subject: pNFS/flexfiles: If the layout is invalid, it must be updated before retrying
From: Trond Myklebust <[email protected]>
commit df3ab232e462bce20710596d697ade6b72497694 upstream.
If we see that our pNFS READ/WRITE/COMMIT operation failed, but we also see that our layout segment is no longer valid, then we need to get a new layout segment before retrying.
--- fs/nfs/flexfilelayout/flexfilelayout.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
fs/nfs/flexfilelayout/flexfilelayout.c +7 -6
@@ -1053,9 +1053,6 @@ static int ff_layout_async_handle_error_struct nfs_client *mds_client = mds_server->nfs_client;struct nfs4_slot_table *tbl = &clp->cl_session->fc_slot_table; -if (task->tk_status >=0 ) -return 0 ; -switch (task->tk_status) {/* MDS state errors */ case -NFS4ERR_DELEG_REVOKED :
@@ -1157,9 +1154,6 @@ static int ff_layout_async_handle_error_ {struct nfs4_deviceid_node *devid =FF_LAYOUT_DEVID_NODE (lseg, idx); -if (task->tk_status >=0 ) -return 0 ; -switch (task->tk_status) {/* File access problems. Don't mark the device as unavailable */ case -EACCES :
@@ -1195,6 +1189,13 @@ static int ff_layout_async_handle_error( {int vers = clp->cl_nfs_mod->rpc_vers->number; +if (task->tk_status >=0 ) +return 0 ; + +/* Handle the case of an invalid layout segment */ +if (!pnfs_is_valid_lseg (lseg)) +return -NFS4ERR_RESET_TO_PNFS ; +switch (vers) {case 3 :return ff_layout_async_handle_error_v3 (task, lseg, idx);
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/nfsv4-fix-reboot-recovery-in-copy-offload.patch queue-4.10/revert-nfsv4.1-handle-nfs4err_badsession-nfs4err_deadsession-replies-to-op_sequence.patch queue-4.10/pnfs-flexfiles-if-the-layout-is-invalid-it-must-be-updated-before-retrying.patch queue-4.10/nfsv4-fix-memory-and-state-leak-in-_nfs4_open_and_get_state.patch