Patch "remoteproc: qcom: mdt_loader: Don't overwrite firmware object" has been added to the 4.10-stable tree
This is a note to let you know that I've just added the patch titled
remoteproc: qcom: mdt_loader: Don't overwrite firmware object
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
remoteproc-qcom-mdt_loader-don-t-overwrite-firmware-object.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
3e8b571a9a0881ba3381ca0915995696da145ab8Mon Sep 17 00:00:00 2001
From: Bjorn Andersson <[email protected]>
Date: Fri, 27 Jan 2017 02:06:36 -0800
Subject: remoteproc: qcom: mdt_loader: Don't overwrite firmware object
From: Bjorn Andersson <[email protected]>
commit 3e8b571a9a0881ba3381ca0915995696da145ab8 upstream.
The "fw" firmware object is passed from the remoteproc core and should not be overwritten, as that results in leaked buffers and a double free of the the last firmware object.
--- drivers/remoteproc/qcom_mdt_loader.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/remoteproc/qcom_mdt_loader.c +4 -3
@@ -116,6 +116,7 @@ int qcom_mdt_load(struct rproc *rproc,const struct elf32_phdr *phdrs;const struct elf32_phdr *phdr;const struct elf32_hdr *ehdr; +const struct firmware *seg_fw;size_t fw_name_len;char *fw_name;void *ptr;
@@ -154,16 +155,16 @@ int qcom_mdt_load(struct rproc *rproc,if (phdr->p_filesz) {sprintf (fw_name + fw_name_len -3 ,"b%02d" , i); - ret =request_firmware (&fw, fw_name, &rproc->dev); + ret =request_firmware (&seg_fw, fw_name, &rproc->dev);if (ret) {dev_err (&rproc->dev,"failed to load %s\n" , fw_name);break ; } -memcpy (ptr, fw->data, fw->size); +memcpy (ptr, seg_fw->data, seg_fw->size); -release_firmware (fw); +release_firmware (seg_fw); }if (phdr->p_memsz > phdr->p_filesz)
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/remoteproc-qcom-mdt_loader-don-t-overwrite-firmware-object.patch