Skip to contentSkip to conversation

fpga: bridge: Replace open-coded list_for_each + list_entry

PATCH In review Moritz Fischer 2 participants 2 messages Mar 10, 2017 – Mar 13, 2017 FPGA manager framework

lore
Share & tools
lore

Moritz Fischer

author maintainer
#0 lore raw

PATCH 1/1 fpga: bridge: Replace open-coded list_for_each + list_entry

Replaces open-coded list_for_each() + list_entry() with macro list_for_each_entry()

Signed-off-by Moritz Fischer <[email protected]>
Cc Alan Tull <[email protected]>
Cc [email protected]
Cc [email protected]
---
 drivers/fpga/fpga-bridge.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/fpga/fpga-bridge.c +4 -11
index 33ee83e..cfacd2e 100644
@@ -146,11 +146,9 @@ EXPORT_SYMBOL_GPL(fpga_bridge_put);
 int fpga_bridges_enable(struct list_head *bridge_list)
 {
 	struct fpga_bridge *bridge;
-	struct list_head *node;
 	int ret;
 
-	list_for_each(node, bridge_list) {
-		bridge = list_entry(node, struct fpga_bridge, node);
+	list_for_each_entry(bridge, bridge_list, node) {
 		ret = fpga_bridge_enable(bridge);
 		if (ret)
 			return ret;

@@ -172,11 +170,9 @@ EXPORT_SYMBOL_GPL(fpga_bridges_enable);
 int fpga_bridges_disable(struct list_head *bridge_list)
 {
 	struct fpga_bridge *bridge;
-	struct list_head *node;
 	int ret;
 
-	list_for_each(node, bridge_list) {
-		bridge = list_entry(node, struct fpga_bridge, node);
+	list_for_each_entry(bridge, bridge_list, node) {
 		ret = fpga_bridge_disable(bridge);
 		if (ret)
 			return ret;

@@ -196,13 +192,10 @@ EXPORT_SYMBOL_GPL(fpga_bridges_disable);
  */
 void fpga_bridges_put(struct list_head *bridge_list)
 {
-	struct fpga_bridge *bridge;
-	struct list_head *node, *next;
+	struct fpga_bridge *bridge, *next;
 	unsigned long flags;
 
-	list_for_each_safe(node, next, bridge_list) {
-		bridge = list_entry(node, struct fpga_bridge, node);
-
+	list_for_each_entry_safe(bridge, next, bridge_list, node) {
 		fpga_bridge_put(bridge);
 
 		spin_lock_irqsave(&bridge_list_lock, flags);
Signature · 1 line
2.7.4