Skip to contentSkip to conversation

hwmon: (it87) Fix feature mask for IT8792E (IT8733E)

PATCH In review Guenter Roeck 1 participant 2 messages Mar 11, 2017 – Mar 20, 2017

Subsystems (2)
Hardware monitoring IT87 hardware monitoring driver
lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (it87) Fix feature mask for IT8792E (IT8733E)

The chip features match those of IT8790E. Most important is the ADC resolution, which is 12 mV, not 10.9 mV. It also uses the 'new' set of registers for PECI control, and has a second PWM frequency register.

Signed-off-by Guenter Roeck <[email protected]>
---
 drivers/hwmon/it87.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/hwmon/it87.c +3 -4
index efb01c247e2d..3e57a6120551 100644
@@ -428,11 +428,10 @@ static const struct it87_devices it87_devices[] = {
 	[it8792] = {
 		.name = "it8792",
 		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
+		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
+		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
+		  | FEAT_PWM_FREQ2,
 		.peci_mask = 0x07,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
 	},
 	[it8603] = {
 		.name = "it8603",
Signature · 1 line
2.7.4
author maintainer
#1 lore raw
Quoted 5 lines · Guenter Roeck

The chip features match those of IT8790E. Most important is the ADC resolution, which is 12 mV, not 10.9 mV. It also uses the 'new' set of registers for PECI control, and has a second PWM frequency register.

Actually, turns out the ADC resolution is wrong. Both chips have an ADC resolution of 10.9mV. Only the datasheet for IT8792E contradicts itself and claims in one place that the resolution is 12mV and elsewhere that it is 10.9mV. A test with a real chip suggests that 10.9mV is correct.

Guenter

Quoted 27 lines
Signed-off-by Guenter Roeck <[email protected]>
---
 drivers/hwmon/it87.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/hwmon/it87.c +3 -4
index efb01c247e2d..3e57a6120551 100644
@@ -428,11 +428,10 @@ static const struct it87_devices it87_devices[] = {
 	[it8792] = {
 		.name = "it8792",
 		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
+		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
+		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
+		  | FEAT_PWM_FREQ2,
 		.peci_mask = 0x07,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
 	},
 	[it8603] = {
 		.name = "it8603",
Signature · 1 line
2.7.4