Skip to contentSkip to conversation

Patch "s390/kdump: Use "LINUX" ELF note name instead of "CORE"" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

s390/kdump: Use "LINUX" ELF note name instead of "CORE"

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
s390-kdump-use-linux-elf-note-name-instead-of-core.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a4a81d8eebdc1d209d034f62a082a5131e4242b5 Mon Sep 17 00:00:00 2001

From: Michael Holzheu <[email protected]>
Date: Tue, 7 Feb 2017 18:09:14 +0100
Subject: s390/kdump: Use "LINUX" ELF note name instead of "CORE"

From: Michael Holzheu <[email protected]>

commit a4a81d8eebdc1d209d034f62a082a5131e4242b5 upstream.

In binutils/libbfd (bfd/elf.c) it is enforced that all s390 specific ELF notes like e.g. NT_S390_PREFIX or NT_S390_CTRS have "LINUX" specified as note name. Otherwise the notes are ignored.

For /proc/vmcore we currently use "CORE" for these notes.

Up to now this has not been a real problem because the dump analysis tool "crash" does not check the note name. But it will break all programs that use libbfd for processing ELF notes.

So fix this and use "LINUX" for all s390 specific notes to comply with libbfd.

---
 arch/s390/kernel/crash_dump.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
arch/s390/kernel/crash_dump.c +5 -1
@@ -329,7 +329,11 @@ static void *nt_init_name(void *buf, Elf
 
 static inline void *nt_init(void *buf, Elf64_Word type, void *desc, int d_len)
 {
-	return nt_init_name(buf, type, desc, d_len, KEXEC_CORE_NOTE_NAME);
+	const char *note_name = "LINUX";
+
+	if (type == NT_PRPSINFO || type == NT_PRSTATUS || type == NT_PRFPREG)
+		note_name = KEXEC_CORE_NOTE_NAME;
+	return nt_init_name(buf, type, desc, d_len, note_name);
 }
 
 /*

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/s390-kdump-use-linux-elf-note-name-instead-of-core.patch