Skip to contentSkip to conversation

pinentry: update to 1.0.0

PATCH In review Armin Kuster 2 participants 4 messages Mar 14, 2017 – Mar 17, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinentry: update to 1.0.0

From: Armin Kuster <[email protected]>

add pkg-config support for libassuan and gpg-error updated config options

---
 .../pinentry/pinentry-1.0.0/gpg-error_pkconf.patch | 100 ++++++++++++++
 .../pinentry-1.0.0/libassuan_pkgconf.patch         | 153 +++++++++++++++++++++
 .../{pinentry_0.9.2.bb => pinentry_1.0.0.bb}       |  22 +--
 3 files changed, 265 insertions(+), 10 deletions(-)
 create mode 100644 meta/recipes-support/pinentry/pinentry-1.0.0/gpg-error_pkconf.patch
 create mode 100644 meta/recipes-support/pinentry/pinentry-1.0.0/libassuan_pkgconf.patch
 rename meta/recipes-support/pinentry/{pinentry_0.9.2.bb => pinentry_1.0.0.bb} (63%)
meta/recipes-support/pinentry/pinentry-1.0.0/gpg-error_pkconf.patch new file +100 -0
new file mode 100644
index 0000000..431edb0
@@ -0,0 +1,100 @@
+Convert to pkg-config support to match changes done to 
+the gpg-error recipe for gpg-error.pc  generation.
+
+Upstream-Status: Inappropriate [OE specific]
+
+Signed-off-by: Armin Kuster <[email protected]>
+
+Index: pinentry-1.0.0/m4/gpg-error.m4
+===================================================================
+--- pinentry-1.0.0.orig/m4/gpg-error.m4
++++ pinentry-1.0.0/m4/gpg-error.m4
+@@ -25,74 +25,12 @@ dnl config script does not match the hos
+ dnl is added to the gpg_config_script_warn variable.
+ dnl
+ AC_DEFUN([AM_PATH_GPG_ERROR],
+-[ AC_REQUIRE([AC_CANONICAL_HOST])
+-  gpg_error_config_prefix=""
+-  dnl --with-libgpg-error-prefix=PFX is the preferred name for this option,
+-  dnl since that is consistent with how our three siblings use the directory/
+-  dnl package name in --with-$dir_name-prefix=PFX.
+-  AC_ARG_WITH(libgpg-error-prefix,
+-              AC_HELP_STRING([--with-libgpg-error-prefix=PFX],
+-                             [prefix where GPG Error is installed (optional)]),
+-              [gpg_error_config_prefix="$withval"])
+-
+-  dnl Accept --with-gpg-error-prefix and make it work the same as
+-  dnl --with-libgpg-error-prefix above, for backwards compatibility,
+-  dnl but do not document this old, inconsistently-named option.
+-  AC_ARG_WITH(gpg-error-prefix,,
+-              [gpg_error_config_prefix="$withval"])
+-
+-  if test x"${GPG_ERROR_CONFIG}" = x ; then
+-     if test x"${gpg_error_config_prefix}" != x ; then
+-        GPG_ERROR_CONFIG="${gpg_error_config_prefix}/bin/gpg-error-config"
+-     else
+-       case "${SYSROOT}" in
+-         /*)
+-           if test -x "${SYSROOT}/bin/gpg-error-config" ; then
+-             GPG_ERROR_CONFIG="${SYSROOT}/bin/gpg-error-config"
+-           fi
+-           ;;
+-         '')
+-           ;;
+-          *)
+-           AC_MSG_WARN([Ignoring \$SYSROOT as it is not an absolute path.])
+-           ;;
+-       esac
+-     fi
+-  fi
+-
+-  AC_PATH_PROG(GPG_ERROR_CONFIG, gpg-error-config, no)
++[
+   min_gpg_error_version=ifelse([$1], ,0.0,$1)
+-  AC_MSG_CHECKING(for GPG Error - version >= $min_gpg_error_version)
+-  ok=no
+-  if test "$GPG_ERROR_CONFIG" != "no" \
+-     && test -f "$GPG_ERROR_CONFIG" ; then
+-    req_major=`echo $min_gpg_error_version | \
+-               sed 's/\([[0-9]]*\)\.\([[0-9]]*\)/\1/'`
+-    req_minor=`echo $min_gpg_error_version | \
+-               sed 's/\([[0-9]]*\)\.\([[0-9]]*\)/\2/'`
+-    gpg_error_config_version=`$GPG_ERROR_CONFIG $gpg_error_config_args --version`
+-    major=`echo $gpg_error_config_version | \
+-               sed 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\1/'`
+-    minor=`echo $gpg_error_config_version | \
+-               sed 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\2/'`
+-    if test "$major" -gt "$req_major"; then
+-        ok=yes
+-    else
+-        if test "$major" -eq "$req_major"; then
+-            if test "$minor" -ge "$req_minor"; then
+-               ok=yes
+-            fi
+-        fi
+-    fi
+-  fi
++  PKG_CHECK_MODULES(GPG_ERROR, [gpg-error >= $min_gpg_error_version gpg-error], [ok=yes], [ok=no])
+   if test $ok = yes; then
+-    GPG_ERROR_CFLAGS=`$GPG_ERROR_CONFIG $gpg_error_config_args --cflags`
+-    GPG_ERROR_LIBS=`$GPG_ERROR_CONFIG $gpg_error_config_args --libs`
+-    GPG_ERROR_MT_CFLAGS=`$GPG_ERROR_CONFIG $gpg_error_config_args --mt --cflags 2>/dev/null`
+-    GPG_ERROR_MT_LIBS=`$GPG_ERROR_CONFIG $gpg_error_config_args --mt --libs 2>/dev/null`
+-    AC_MSG_RESULT([yes ($gpg_error_config_version)])
+     ifelse([$2], , :, [$2])
+-    gpg_error_config_host=`$GPG_ERROR_CONFIG $gpg_error_config_args --host 2>/dev/null || echo none`
++    gpg_error_config_host=`$PKG_CONFIG --host gpg-error 2>/dev/null || echo none`
+     if test x"$gpg_error_config_host" != xnone ; then
+       if test x"$gpg_error_config_host" != x"$host" ; then
+   AC_MSG_WARN([[
+@@ -107,10 +45,6 @@ AC_DEFUN([AM_PATH_GPG_ERROR],
+       fi
+     fi
+   else
+-    GPG_ERROR_CFLAGS=""
+-    GPG_ERROR_LIBS=""
+-    GPG_ERROR_MT_CFLAGS=""
+-    GPG_ERROR_MT_LIBS=""
+     AC_MSG_RESULT(no)
+     ifelse([$3], , :, [$3])
+   fi
meta/recipes-support/pinentry/pinentry-1.0.0/libassuan_pkgconf.patch new file +153 -0

153 lines not on this page · raw message

meta/recipes-support/pinentry/pinentry_1.0.0.bb renamed from meta/recipes-support/pinentry/pinentry_0.9.2.bb +12 -10
similarity index 63%
rename from meta/recipes-support/pinentry/pinentry_0.9.2.bb
rename to meta/recipes-support/pinentry/pinentry_1.0.0.bb
index d315a99..319acd3 100644
@@ -8,26 +8,28 @@ HOMEPAGE = "http://www.gnupg.org/related_software/pinentry/index.en.html"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cbbd794e2a0a289b9dfcc9f513d1996e"
 
-inherit autotools
+inherit autotools pkgconfig
 
-DEPENDS = "gettext-native"
+DEPENDS = "gettext-native libassuan libgpg-error"
 
 UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html"
-SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2"
+SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \
+           file://libassuan_pkgconf.patch \
+           file://gpg-error_pkconf.patch \
+"
 
-SRC_URI[md5sum] = "f51d454f921111b5156a2291cbf70278"
-SRC_URI[sha256sum] = "fd8bc1592ceb22bb492b07cb29b1b140bb882c859e6503b974254c0a4b4134d1"
+SRC_URI[md5sum] = "4a3fad8b31f9b4c5526c8837495015dc"
+SRC_URI[sha256sum] = "1672c2edc1feb036075b187c0773787b2afd0544f55025c645a71b4c2f79275a"
 
-EXTRA_OECONF = "--disable-rpath \
-		        --disable-dependency-tracking \
-               "
+EXTRA_OECONF = "--disable-rpath --disable-dependency-tracking \
+                --disable-pinentry-qt5  \
+"
 
 PACKAGECONFIG ??= "ncurses libcap"
 
 PACKAGECONFIG[ncurses] = "--enable-ncurses  --with-ncurses-include-dir=${STAGING_INCDIR}, --disable-ncurses, ncurses"
 PACKAGECONFIG[libcap] = "--with-libcap, --without-libcap, libcap"
-PACKAGECONFIG[qt4] = "--enable-pinentry-qt4, --disable-pinentry-qt4, qt4-x11"
-PACKAGECONFIG[qt4_clipboard] = "--enable-pinentry-qt4-clipboard --enable-pinentry-qt4, --disable-pinentry-qt4-clipboard, qt4-x11"
+PACKAGECONFIG[qt] = "--enable-pinentry-qt, --disable-pinentry-qt, qt4-x11"
 PACKAGECONFIG[gtk2] = "--enable-pinentry-gtk2, --disable-pinentry-gtk2, gtk+ glib-2.0"
 
 #To use libsecret, add meta-gnome
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · Armin Kuster

add pkg-config support for libassuan and gpg-error updated config options

This didn't quite make M3 so strictly speaking upgrades have to wait. Can you backport the fixes to 0.9.2, or is there a sufficiently good reason to make an exception for the 1.0 upgrade?

Ross

author
#2 lore raw
Quoted 8 lines · Ross

On 14 March 2017 at 02:39, Armin Kuster <[email protected] <mailto:[email protected]>> wrote:

add pkg-config support for libassuan and gpg-error updated config options

This didn't quite make M3

Didn't expect it make it in. My intend was for master-to-exclude-2.3-changes branch.

Quoted 1 line

so strictly speaking upgrades have to wait. Can you backport the fixes to 0.9.2,

geez, you are making me think now. I don't recall if there where any issues with 0.9.2 building. I am traveling and wont have a chance to look into it for a day or two.

Quoted 1 line

or is there a sufficiently good reason to make an exception for the 1.0 upgrade?

nope. Finally sat down to hammer out the update.

thanks for getting back to me.

kind regards,
Armin

Quoted 2 lines

Ross

#3 lore raw
Quoted 3 lines · On 17 March 2017 at 17:52, akuster808 <[email protected]> wrote:

Didn't expect it make it in. My intend was for
master-to-exclude-2.3-changes branch.

Cool, good to know. It can be the inaugural patch in ross/later. :)

Thanks,
Ross