Skip to contentSkip to conversation

drm/msm/hdmi: redefinitions of macros not required

PATCH In review Vinay Simha BN 2 participants 3 messages Mar 14, 2017 – Mar 22, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/hdmi: redefinitions of macros not required

4 macros already defined in hdmi.h,
which is not required to redefine in hdmi_audio.c

---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/msm/hdmi/hdmi_audio.c +0 -7
index a54d3bb..8177e85 100644
@@ -18,13 +18,6 @@
 #include <linux/hdmi.h>
 #include "hdmi.h"
 
-
-/* Supported HDMI Audio channels */
-#define MSM_HDMI_AUDIO_CHANNEL_2		0
-#define MSM_HDMI_AUDIO_CHANNEL_4		1
-#define MSM_HDMI_AUDIO_CHANNEL_6		2
-#define MSM_HDMI_AUDIO_CHANNEL_8		3
-
 /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of channels: */
 static int nchannels[] = { 2, 4, 6, 8 };
 
Signature · 1 line
2.7.4
#1 lore raw

hi,

Could you please give some feedback or review comments for this patch

Quoted 32 lines · Vinay Simha BN

4 macros already defined in hdmi.h,
which is not required to redefine in hdmi_audio.c

---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/msm/hdmi/hdmi_audio.c +0 -7
index a54d3bb..8177e85 100644
@@ -18,13 +18,6 @@
 #include <linux/hdmi.h>
 #include "hdmi.h"
 
-
-/* Supported HDMI Audio channels */
-#define MSM_HDMI_AUDIO_CHANNEL_2		0
-#define MSM_HDMI_AUDIO_CHANNEL_4		1
-#define MSM_HDMI_AUDIO_CHANNEL_6		2
-#define MSM_HDMI_AUDIO_CHANNEL_8		3
-
 /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of

channels: */
static int nchannels[] = { 2, 4, 6, 8 };

--
2.7.4

Signature · 6 lines
regards,
vinaysimha
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
#2 lore raw
Quoted 3 lines · Vinay Simha B N

hi,

Could you please give some feedback or review comments for this patch

looks good, I've pulled it into msm-next

BR,
-R

Quoted 29 lines · Vinay Simha BN
Quoted 28 lines

4 macros already defined in hdmi.h,
which is not required to redefine in hdmi_audio.c

---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/msm/hdmi/hdmi_audio.c +0 -7
index a54d3bb..8177e85 100644
@@ -18,13 +18,6 @@
 #include <linux/hdmi.h>
 #include "hdmi.h"
 
-
-/* Supported HDMI Audio channels */
-#define MSM_HDMI_AUDIO_CHANNEL_2             0
-#define MSM_HDMI_AUDIO_CHANNEL_4             1
-#define MSM_HDMI_AUDIO_CHANNEL_6             2
-#define MSM_HDMI_AUDIO_CHANNEL_8             3
-
 /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of

channels: */
static int nchannels[] = { 2, 4, 6, 8 };

Quoted 9 lines
Quoted 4 lines

--
2.7.4

--
regards,
vinaysimha

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel