ks7010: adding parenthesis to macro argument
PATCH 1/1 ks7010: adding parenthesis to macro argument
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params. Also, removing extra line.
--- drivers/staging/ks7010/ks7010_sdio.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +6 -7
@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);/* macro */ #define inc_txqhead (priv) \ - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)#define inc_txqtail (priv) \ - (priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qtail = ((priv)->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE)#define cnt_txqbody (priv) \ - (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE) + ((((priv)->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - ((priv)->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE)#define inc_rxqhead (priv) \ - (priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE) + ((priv)->rx_dev.qhead = ((priv)->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE)#define inc_rxqtail (priv) \ - (priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE) + ((priv)->rx_dev.qtail = ((priv)->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE)#define cnt_rxqbody (priv) \ - (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE) + ((((priv)->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - ((priv)->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE)static int ks7010_sdio_read (struct ks_wlan_private *priv,unsigned int address,unsigned char *buffer,int length)
@@ -884,7 +884,6 @@ static void ks7010_card_init(struct ks_wlan_private *priv)if (priv->mac_address_valid && priv->version_size) priv->dev_state =DEVICE_STATE_PREINIT ; -hostif_sme_enqueue (priv,SME_GET_EEPROM_CKSUM );/* load initial wireless parameter */
Signature · 1 line
2.7.4
Quoted 3 lines · Pushkar Jambhlekar
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params. Also, removing extra line.
Don't do this as one patch.
Quoted 11 lines
Signed-off-by Pushkar Jambhlekar <[email protected]>--- drivers/staging/ks7010/ks7010_sdio.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)drivers/staging/ks7010/ks7010_sdio.c +0
-0
drivers/staging/ks7010/ks7010_sdio.c MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids); · line 38
Quoted 5 lines
drivers/staging/ks7010/ks7010_sdio.c +1
-1@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);/* macro */ #define inc_txqhead (priv) \ - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
I can't get excited about this at all. Make it a function or leave it alone.
regards,
dan carpenter
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not super exciting, no harm to follow correct way.
Quoted 30 lines · Dan Carpenter
Quoted 3 lines · Pushkar Jambhlekar
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params. Also, removing extra line.Don't do this as one patch.
Quoted 11 lines
Signed-off-by Pushkar Jambhlekar <[email protected]>--- drivers/staging/ks7010/ks7010_sdio.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)drivers/staging/ks7010/ks7010_sdio.c +0
-0drivers/staging/ks7010/ks7010_sdio.c MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids); · line 38
Quoted 5 lines
drivers/staging/ks7010/ks7010_sdio.c +1
-1@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);/* macro */ #define inc_txqhead (priv) \ - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE) + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)I can't get excited about this at all. Make it a function or leave it alone.
regards,
dan carpenter
Signature · 2 lines
Jambhlekar Pushkar Arun M.Tech IIT Roorkee
Quoted 5 lines · Pushkar Jambhlekar
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not super exciting, no harm to follow correct way.
The harm is that it takes something that's already terrible and makes it even more unreadable.
regards,
dan carpenter