Skip to contentSkip to conversation

FAILED: patch "[PATCH] [media] rc: raw decoder for keymap protocol is not loaded on" failed to apply to 4.10-stable tree

PATCH [email protected] 2 participants 2 messages Mar 15, 2017

Subsystems (3)
Stable branch Media (V4L/DVB) RC-core / lirc framework
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 413808685dd7c9b54bbc5af79da2eaddd0fc3cb2 Mon Sep 17 00:00:00 2001

From: Sean Young <[email protected]>
Date: Wed, 22 Feb 2017 18:48:01 -0300
Subject: [PATCH] [media] rc: raw decoder for keymap protocol is not loaded on
register

When the protocol is set via the sysfs protocols attribute, the decoder is loaded. However, when it is not when a device is first plugged in or registered.

Fixes acc1c3c ("[media] media: rc: load decoder modules on-demand")
Signed-off-by Sean Young <[email protected]>
Cc <[email protected]> # v4.5+
Signed-off-by Mauro Carvalho Chehab <[email protected]>
drivers/media/rc/rc-main.c +6 -2
index 2424946740e6..a158b321b40a 100644
@@ -1663,6 +1663,7 @@ static int rc_setup_rx_device(struct rc_dev *dev)
 {
 	int rc;
 	struct rc_map *rc_map;
+	u64 rc_type;
 
 	if (!dev->map_name)
 		return -EINVAL;

@@ -1677,15 +1678,18 @@ static int rc_setup_rx_device(struct rc_dev *dev)
 	if (rc)
 		return rc;
 
-	if (dev->change_protocol) {
-		u64 rc_type = (1ll << rc_map->rc_type);
+	rc_type = BIT_ULL(rc_map->rc_type);
 
+	if (dev->change_protocol) {
 		rc = dev->change_protocol(dev, &rc_type);
 		if (rc < 0)
 			goto out_table;
 		dev->enabled_protocols = rc_type;
 	}
 
+	if (dev->driver_type == RC_DRIVER_IR_RAW)
+		ir_raw_load_modules(&rc_type);
+
 	set_bit(EV_KEY, dev->input_dev->evbit);
 	set_bit(EV_REP, dev->input_dev->evbit);
 	set_bit(EV_MSC, dev->input_dev->evbit);
maintainer
#1 lore raw
Quoted 22 lines · On Wed, Mar 15, 2017 at 03:30:50PM +0800, [email protected] wrote:

The patch below does not apply to the 4.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 413808685dd7c9b54bbc5af79da2eaddd0fc3cb2 Mon Sep 17 00:00:00 2001

From: Sean Young <[email protected]>
Date: Wed, 22 Feb 2017 18:48:01 -0300
Subject: [PATCH] [media] rc: raw decoder for keymap protocol is not loaded on
register

When the protocol is set via the sysfs protocols attribute, the decoder is loaded. However, when it is not when a device is first plugged in or registered.

Quoted 6 lines
Fixes acc1c3c ("[media] media: rc: load decoder modules on-demand")
Signed-off-by Sean Young <[email protected]>
Cc <[email protected]> # v4.5+
Signed-off-by Mauro Carvalho Chehab <[email protected]>

Backported to v4.10.3 and tested:

Quoted 1 line

From 1178b692ec0533a01df895d892c93c1506fa013b Mon Sep 17 00:00:00 2001

From: Sean Young <[email protected]>
Date: Wed, 15 Mar 2017 10:51:43 +0000
Subject: [PATCH] [media] rc: raw decoder for keymap protocol is not loaded on
register

When the protocol is set via the sysfs protocols attribute, the decoder is loaded. However, when it is not when a device is first plugged in or registered.

Fixes acc1c3c ("[media] media: rc: load decoder modules on-demand")
Signed-off-by Sean Young <[email protected]>
Cc <[email protected]> # v4.5+
Signed-off-by Mauro Carvalho Chehab <[email protected]>
---
 drivers/media/rc/rc-main.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/media/rc/rc-main.c +6 -1
index dedaf38..9a397da 100644
@@ -1441,6 +1441,7 @@ int rc_register_device(struct rc_dev *dev)
 	int attr = 0;
 	int minor;
 	int rc;
+	u64 rc_type;
 
 	if (!dev || !dev->map_name)
 		return -EINVAL;

@@ -1526,14 +1527,18 @@ int rc_register_device(struct rc_dev *dev)
 			goto out_input;
 	}
 
+	rc_type = BIT_ULL(rc_map->rc_type);
+
 	if (dev->change_protocol) {
-		u64 rc_type = (1ll << rc_map->rc_type);
 		rc = dev->change_protocol(dev, &rc_type);
 		if (rc < 0)
 			goto out_raw;
 		dev->enabled_protocols = rc_type;
 	}
 
+	if (dev->driver_type == RC_DRIVER_IR_RAW)
+		ir_raw_load_modules(&rc_type);
+
 	/* Allow the RC sysfs nodes to be accessible */
 	atomic_set(&dev->initialized, 1);
Signature · 1 line
2.9.3