Patch "Revert "usb: gadget: uvc: Add missing call for additional setup data"" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
Revert "usb: gadget: uvc: Add missing call for additional setup data"
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-usb-gadget-uvc-add-missing-call-for-additional-setup-data.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
eb38d913c27f32f4df173791051fecf6aca34173Mon Sep 17 00:00:00 2001
From: Roger Quadros <[email protected]>
Date: Thu, 2 Mar 2017 10:44:58 +0200
Subject: Revert "usb: gadget: uvc: Add missing call for additional setup data"
From: Roger Quadros <[email protected]>
commit eb38d913c27f32f4df173791051fecf6aca34173 upstream.
This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b.
This commit breaks g_webcam when used with uvc-gadget [1].
The user space application (e.g. uvc-gadget) is responsible for sending response to UVC class specific requests on control endpoint in uvc_send_response() in uvc_v4l2.c.
The bad commit was causing a duplicate response to be sent with incorrect response data thus causing UVC probe to fail at the host and broken control transfer endpoint at the gadget.
[1] - git://git.ideasonboard.org/uvc-gadget.git
--- drivers/usb/gadget/function/f_uvc.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/usb/gadget/function/f_uvc.c +0 -7
@@ -258,13 +258,6 @@ uvc_function_setup(struct usb_function *memcpy (&uvc_event->req, ctrl,sizeof (uvc_event->req));v4l2_event_queue (&uvc->vdev, &v4l2_event); -/* Pass additional setup data to userspace */ -if (uvc->event_setup_out && uvc->event_length) { - uvc->control_req->length = uvc->event_length; -return usb_ep_queue (uvc->func.config->cdev->gadget->ep0, - uvc->control_req,GFP_ATOMIC ); - } -return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/usb-dwc3-omap-fix-missing-break-in-dwc3_omap_set_mailbox.patch queue-4.9/revert-usb-gadget-uvc-add-missing-call-for-additional-setup-data.patch