Skip to contentSkip to conversation

Fix: text output missing separator when printing the domain

PATCH Jérémie Galarneau 1 participant 1 message May 26, 2017 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Merged in master, stable-1.5, and stable-1.4. Thanks!

Jérémie

Quoted 28 lines · Julien Desfossez

With the "-f all" option, we expect to see <hostname>:<domain>:<loglevel>, but instead we see <hostname><domain>:<loglevel>.

Judging from the pattern of the other printed fields, the check for "dom_print" variable seems to be missing when printing the domain.

---
 formats/ctf-text/ctf-text.c | 2 ++
 1 file changed, 2 insertions(+)
formats/ctf-text/ctf-text.c +2 -1
index f615161..69450cf 100644
@@ -350,6 +350,8 @@ int ctf_text_write_event(struct bt_stream_pos *ppos, struct ctf_stream_definitio
                set_field_names_print(pos, ITEM_HEADER);
                if (pos->print_names) {
                        fprintf(pos->fp, "trace:domain = ");
+               } else if (dom_print) {
+                       fprintf(pos->fp, ":");
                }
                fprintf(pos->fp, "%s", stream_class->trace->env.domain);
                if (pos->print_names)
--

2.7.4

Signature · 7 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev