Patch "crypto: powerpc - Fix initialisation of crc32c context" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
crypto: powerpc - Fix initialisation of crc32c context
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-powerpc-fix-initialisation-of-crc32c-context.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213Mon Sep 17 00:00:00 2001
From: Daniel Axtens <[email protected]>
Date: Fri, 3 Mar 2017 17:56:55 +1100
Subject: crypto: powerpc - Fix initialisation of crc32c context
From: Daniel Axtens <[email protected]>
commit aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 upstream.
Turning on crypto self-tests on a POWER8 shows:
alg: hash: Test 1 failed for crc32c-vpmsum
00000000: ff ff ff ff
Comparing the code with the Intel CRC32c implementation on which ours is based shows that we are doing an init with 0, not ~0 as CRC32c requires.
This probably wasn't caught because btrfs does its own weird open-coded initialisation.
Initialise our internal context to ~0 on init.
This makes the self-tests pass, and btrfs continues to work.
--- arch/powerpc/crypto/crc32c-vpmsum_glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/crypto/crc32c-vpmsum_glue.c +1 -1
@@ -52,7 +52,7 @@ static int crc32c_vpmsum_cra_init(struct {u32 *key =crypto_tfm_ctx (tfm); - *key =0 ; + *key = ~0 ;return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/crypto-powerpc-fix-initialisation-of-crc32c-context.patch