Skip to contentSkip to conversation

COLO:Fix Colo doc, secondeary should be secondary

PATCH In review wangguang 3 participants 3 messages Mar 21, 2017 – Oct 30, 2018

lore
Share & tools
lore

wangguang

author
#0 lore raw

PATCH v4 1/1 COLO:Fix Colo doc, secondeary should be secondary

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error in COLO-FT.txt.
secondeary-disk0 should be secondary-disk0.

Signed-off-by Guang Wang <[email protected]>

---

 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/COLO-FT.txt +0 -0
index e289be2..bec7547 100644 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',

'port': '8889'} } }
}
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable': true } }
+{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0', 'writable': true } }

Note:
a. The qmp command nbd-server-start and nbd-server-add must be run

Signature · 9 lines
2.9.3 





--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v4-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474433.html
Sent from the Developer mailing list archive at Nabble.com.
Reviewed-by on v4 1/1
#1 lore raw

[adding qemu-trivial]

Quoted 1 line · wangguang

Subject: [PATCH] Fix Colo doc secondeary should be secondary

This line feels redundant compared to the overall mail's subject line. In turn, that subject could use a space after colon.

Quoted 7 lines

This is an error in COLO-FT.txt.
secondeary-disk0 should be secondary-disk0.

Signed-off-by Guang Wang <[email protected]>

---

 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Eric Blake <[email protected]>

As it is doc-only, it is safe for hard freeze, but also not the end of the world if it doesn't go in until 2.10.

Quoted 18 lines
docs/COLO-FT.txt +1 -1
index e289be2..bec7547 100644 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
 'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
 'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
 'writable': true } }

Note:
a. The qmp command nbd-server-start and nbd-server-add must be run

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#2 lore raw
Quoted 16 lines · * Eric Blake ([email protected]) wrote:

[adding qemu-trivial]

Quoted 1 line · wangguang

Subject: [PATCH] Fix Colo doc secondeary should be secondary

This line feels redundant compared to the overall mail's subject line. In turn, that subject could use a space after colon.

Quoted 7 lines

This is an error in COLO-FT.txt.
secondeary-disk0 should be secondary-disk0.

Signed-off-by Guang Wang <[email protected]>

---

 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Reviewed-by Eric Blake <[email protected]>

As it is doc-only, it is safe for hard freeze, but also not the end of the world if it doesn't go in until 2.10.

Manually applied and queued for migration
(ahem a little late)

Dave

Quoted 15 lines
Quoted 15 lines
docs/COLO-FT.txt +1 -1
index e289be2..bec7547 100644 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
 'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
 'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
 'writable': true } }
Quoted 8 lines
Quoted 3 lines

Note:
a. The qmp command nbd-server-start and nbd-server-add must be run

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK