Skip to contentSkip to conversation

drm/scdc: declare drm_scdc_get_scrambling_status

PATCH In review Jani Nikula 3 participants 4 messages Mar 22, 2017 – Mar 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/scdc: declare drm_scdc_get_scrambling_status

Fix sparse warning:

drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol 'drm_scdc_get_scrambling_status' was not declared. Should it be static?

Fixes 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB")
Cc Shashank Sharma <[email protected]>
---
 include/drm/drm_scdc_helper.h | 2 ++
 1 file changed, 2 insertions(+)
include/drm/drm_scdc_helper.h +2 -0
index ab6bcfbceba9..c25122bb490a 100644
@@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset,
 	return drm_scdc_write(adapter, offset, &value, sizeof(value));
 }
 
+bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter);
+
 /**
  * drm_scdc_set_scrambling - enable scrambling
  * @adapter: I2C adapter for DDC channel
Signature · 6 lines
2.1.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

✓ Fi.CI.BAT: success for drm/scdc: declare drm_scdc_get_scrambling_status

== Series Details ==

== Series Details ==

Series: drm/scdc: declare drm_scdc_get_scrambling_status
URL : https://patchwork.freedesktop.org/series/21690/
State : success

== Summary ==

Series 21690v1 drm/scdc: declare drm_scdc_get_scrambling_status
https://patchwork.freedesktop.org/api/1.0/series/21690/revisions/1/mbox/

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 457s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time: 465s
fi-bsw-n3050     total:278  pass:239  dwarn:0   dfail:0   fail:0   skip:39  time: 579s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 546s
fi-byt-j1900     total:278  pass:251  dwarn:0   dfail:0   fail:0   skip:27  time: 510s
fi-byt-n2820     total:278  pass:247  dwarn:0   dfail:0   fail:0   skip:31  time: 505s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 435s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 435s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 448s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 520s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 498s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 481s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 483s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time: 599s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 492s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 520s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time: 458s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 548s
fi-snb-2600      total:278  pass:248  dwarn:0   dfail:0   fail:1   skip:29  time: 415s

1595c9b1bafa002ccfaa484f1dd3b2d7b9303a64 drm-tip: 2017y-03m-22d-09h-09m-59s UTC integration manifest da0347c drm/scdc: declare drm_scdc_get_scrambling_status

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4263/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jani Nikula

Thanks for this patch, Jani.

Regards
Shashank

Quoted 17 lines · Jani Nikula

Fix sparse warning:

drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol 'drm_scdc_get_scrambling_status' was not declared. Should it be static?

Fixes 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB")
Cc Shashank Sharma <[email protected]>
---
  include/drm/drm_scdc_helper.h | 2 ++
  1 file changed, 2 insertions(+)
include/drm/drm_scdc_helper.h +0 -0
index ab6bcfbceba9..c25122bb490a 100644

include/drm/drm_scdc_helper.h static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset, · line 136

Quoted 8 lines
include/drm/drm_scdc_helper.h +2 -0
@@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset,
  	return drm_scdc_write(adapter, offset, &value, sizeof(value));
  }
 
+bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter);
+
  /**
   * drm_scdc_set_scrambling - enable scrambling
   * @adapter: I2C adapter for DDC channel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 3 lines · Shashank

Thanks for this patch, Jani.

And pushed to drm-misc-next, thanks for the review.

BR,
Jani.

Quoted 31 lines

Regards
Shashank

Quoted 25 lines · Jani Nikula

Fix sparse warning:

drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol 'drm_scdc_get_scrambling_status' was not declared. Should it be static?

Fixes 62c58af32c93 ("drm/edid: detect SCDC support in HF-VSDB")
Cc Shashank Sharma <[email protected]>
---
  include/drm/drm_scdc_helper.h | 2 ++
  1 file changed, 2 insertions(+)
include/drm/drm_scdc_helper.h +2 -0
index ab6bcfbceba9..c25122bb490a 100644
@@ -129,6 +129,8 @@ static inline int drm_scdc_writeb(struct i2c_adapter *adapter, u8 offset,
  	return drm_scdc_write(adapter, offset, &value, sizeof(value));
  }
 
+bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter);
+
  /**
   * drm_scdc_set_scrambling - enable scrambling
   * @adapter: I2C adapter for DDC channel
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx