Skip to contentSkip to conversation

drivers/staging/dgnc: Removing manual function tracing using dev_dbg

PATCH In review Pushkar Jambhlekar 2 participants 2 messages Mar 23, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/staging/dgnc: Removing manual function tracing using dev_dbg

Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant.

---
 drivers/staging/dgnc/dgnc_tty.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +0 -4
index f7e754e..cae0410 100644
@@ -1858,13 +1858,9 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
 	if (!bd || bd->magic != DGNC_BOARD_MAGIC)
 		return;
 
-	dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
-
 	spin_lock_irqsave(&ch->ch_lock, flags);
 	bd->bd_ops->send_immediate_char(ch, c);
 	spin_unlock_irqrestore(&ch->ch_lock, flags);
-
-	dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n");
 }
 
 /* Return modem signals to ld. */
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Pushkar Jambhlekar

Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant.

Always wrap your changelog lines properly.

Also, someone else sent this same patch in right before you did, sorry.

greg k-h