Skip to contentSkip to conversation

libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host

PATCH In review Tristan Van Berkom 2 participants 2 messages Mar 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host

This is already filed in the appropriate bugzilla:
   https://bugzilla.yoctoproject.org/show_bug.cgi?id=11240

Just notifying the list as the custom goes...

libjpeg-turbo in recipes-graphics has an unconditional dependency on nasm-native, which is intel specific and wont be provided on non intel arches.

Attaching a patch which fixes this by only requiring nasm-native when targeting intel architectures.

Cheers,
    -Tristan

From 29a82ba25a9c395f5214699ca0afb5bd465ebdf1 Mon Sep 17 00:00:00 2001
From: Tristan Van Berkom <[email protected]>
Date: Fri, 24 Mar 2017 15:37:36 +0000
Subject: [PATCH] libjpeg-turbo: Support building on non intel targets.

nasm is intel specific, however libjpeg-turbo is still desirable on other architectures.

Without this patch, it would seem that nasm is built on an intel host and then ignored when compiling libjpeg-turbo for an arm target, however it has libjpeg-turbo requiring nasm be built when building on an arm/aarch64 host.

This fixes the issue so that nasm-native is not required on the host when building for an aarch64 target.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.0.bb +2 -1
index c9e70d73d2..a02406eaa6 100644
@@ -7,7 +7,8 @@ LIC_FILES_CHKSUM = "file://cdjpeg.h;endline=13;md5=05bab7c7ad899d85bfba60da1a127
                     file://jpeglib.h;endline=16;md5=f67d70e547a2662c079781c72f877f72 \
                     file://djpeg.c;endline=11;md5=b90b6d2b4119f9e5807cd273f525d2af \
 "
-DEPENDS = "nasm-native"
+DEPENDS_append_x86-64 = " nasm-native"
+DEPENDS_append_x86    = " nasm-native"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "3fc5d9b6a8bce96161659ae7a9939257"
Signature · 1 line
2.11.0
#1 lore raw

✗ patchtest: failure for libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host

== Series Details ==

Series: libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host
Revision: 1
URL : https://patchwork.openembedded.org/series/5967/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 3b5ac72bdf)

* Patch            libjpeg-turbo fails to build for aarch64/arm targets on aarch64 host
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe