Patch "net/mlx5e: Count LRO packets correctly" has been added to the 4.4-stable tree
This is a note to let you know that I've just added the patch titled
net/mlx5e: Count LRO packets correctly
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx5e-count-lro-packets-correctly.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Mar 27 18:22:09 CEST 2017
From: Gal Pressman <[email protected]>
Date: Tue, 21 Mar 2017 15:59:19 +0200
Subject: net/mlx5e: Count LRO packets correctly
From: Gal Pressman <[email protected]>
[ Upstream commit 8ab7e2ae15d84ba758b2c8c6f4075722e9bd2a08 ]
RX packets statistics ('rx_packets' counter) used to count LRO packets as one, even though it contains multiple segments.
This patch will increment the counter by the number of segments, and align the driver with the behavior of other drivers in the stack.
Note that no information is lost in this patch due to 'rx_lro_packets' counter existence.
Before, ethtool showed:
$ ethtool -S ens6 | egrep "rx_packets|rx_lro_packets"
rx_packets: 435277
rx_lro_packets: 35847
rx_packets_phy: 1935066Now, we will see the more logical statistics:
$ ethtool -S ens6 | egrep "rx_packets|rx_lro_packets"
rx_packets: 1935066
rx_lro_packets: 35847
rx_packets_phy: 1935066--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +4 -0
@@ -197,6 +197,10 @@ static inline void mlx5e_build_rx_skb(stif (lro_num_seg >1 ) {mlx5e_lro_update_hdr (skb, cqe);skb_shinfo (skb)->gso_size =DIV_ROUND_UP (cqe_bcnt, lro_num_seg); +/* Subtract one since we already counted this as one +* "regular" packet in mlx5e_complete_rx_cqe() +*/ + rq->stats.packets += lro_num_seg -1 ; rq->stats.lro_packets++; rq->stats.lro_bytes += cqe_bcnt; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/net-mlx5e-count-lro-packets-correctly.patch