Skip to contentSkip to conversation

Patch "iio: magnetometer: ak8974: remove incorrect __exit markups" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 27, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: magnetometer: ak8974: remove incorrect __exit markups

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-magnetometer-ak8974-remove-incorrect-__exit-markups.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3ff861f59f6c1f5bf2bc03d2cd36ac3f992cbc06 Mon Sep 17 00:00:00 2001

From: Dmitry Torokhov <[email protected]>
Date: Wed, 1 Mar 2017 15:37:57 -0800
Subject: iio: magnetometer: ak8974: remove incorrect __exit markups

From: Dmitry Torokhov <[email protected]>

commit 3ff861f59f6c1f5bf2bc03d2cd36ac3f992cbc06 upstream.

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

---
 drivers/iio/magnetometer/ak8974.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/ak8974.c +2 -2
@@ -767,7 +767,7 @@ power_off:
 	return ret;
 }
 
-static int __exit ak8974_remove(struct i2c_client *i2c)
+static int ak8974_remove(struct i2c_client *i2c)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(i2c);
 	struct ak8974 *ak8974 = iio_priv(indio_dev);
@@ -849,7 +849,7 @@ static struct i2c_driver ak8974_driver =
 		.of_match_table = of_match_ptr(ak8974_of_match),
 	},
 	.probe	  = ak8974_probe,
-	.remove	  = __exit_p(ak8974_remove),
+	.remove	  = ak8974_remove,
 	.id_table = ak8974_id,
 };
 module_i2c_driver(ak8974_driver);

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch queue-4.10/iio-magnetometer-ak8974-remove-incorrect-__exit-markups.patch queue-4.10/input-cm109-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-iforce-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-alps-fix-v8-protocol-handling-73-03-28.patch queue-4.10/input-kbtab-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-sur40-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-elan_i2c-add-asus-eeebook-x205ta-special-touchpad-fw.patch queue-4.10/input-hanwang-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-alps-fix-trackstick-button-handling-on-v8-devices.patch queue-4.10/input-yealink-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-i8042-add-noloop-quirk-for-dell-embedded-box-pc-3000.patch