Skip to contentSkip to conversation

Patch "pinctrl: qcom: Don't clear status bit on irq_unmask" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 30, 2017

Subsystems (5)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pinctrl: qcom: Don't clear status bit on irq_unmask

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pinctrl-qcom-don-t-clear-status-bit-on-irq_unmask.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a6566710adaa4a7dd5e0d99820ff9c9c30ee5951 Mon Sep 17 00:00:00 2001

From: Bjorn Andersson <[email protected]>
Date: Tue, 14 Mar 2017 08:23:26 -0700
Subject: pinctrl: qcom: Don't clear status bit on irq_unmask

From: Bjorn Andersson <[email protected]>

commit a6566710adaa4a7dd5e0d99820ff9c9c30ee5951 upstream.

Clearing the status bit on irq_unmask will discard any pending interrupt that did arrive after the irq_ack, i.e. while the IRQ handler function was executing.

Fixes f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
Cc Stephen Boyd <[email protected]>
---
 drivers/pinctrl/qcom/pinctrl-msm.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/pinctrl/qcom/pinctrl-msm.c +0 -4
@@ -597,10 +597,6 @@ static void msm_gpio_irq_unmask(struct i
 
 	spin_lock_irqsave(&pctrl->lock, flags);
 
-	val = readl(pctrl->regs + g->intr_status_reg);
-	val &= ~BIT(g->intr_status_bit);
-	writel(val, pctrl->regs + g->intr_status_reg);
-
 	val = readl(pctrl->regs + g->intr_cfg_reg);
 	val |= BIT(g->intr_enable_bit);
 	writel(val, pctrl->regs + g->intr_cfg_reg);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/pinctrl-qcom-don-t-clear-status-bit-on-irq_unmask.patch